fix: resolve SonarQube findings and Next.js Image warnings

SonarQube/SonarLint fixes:
- Remove unused imports (useMemo, PROVIDER_ENDPOINTS, updateSettings, APP_CONFIG)
- Add PropTypes validation to all components receiving props
- Fix accessibility issues (semantic buttons, ARIA attributes, form labels)
- Replace array index keys with stable identifiers
- Extract duplicate getStatusDisplay function in providers page
- Fix negated conditions for better readability
- Add node: prefix to Node.js imports in localDb.js
- Fix optional chaining in pricing lookup
- Add explanatory comments to empty catch blocks
- Consolidate duplicate OAuth flow branches
- Change parseInt to Number.parseInt
- Disable false positive rules in VS Code settings

Next.js Image fixes:
- Add style={{ width: "auto", height: "auto" }} to all Image components
- Resolves aspect ratio warnings without triggering lint issues

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
apeltekci 2026-01-19 15:31:08 -08:00 committed by decolua
parent d9b8e48725
commit 7058b062e7
14 changed files with 307 additions and 156 deletions

View file

@ -1,11 +1,11 @@
"use client";
import { usePathname } from "next/navigation";
import { usePathname, useRouter } from "next/navigation";
import Link from "next/link";
import Image from "next/image";
import { useRouter } from "next/navigation";
import PropTypes from "prop-types";
import { ThemeToggle } from "@/shared/components";
import { APP_CONFIG, OAUTH_PROVIDERS, APIKEY_PROVIDERS } from "@/shared/constants/config";
import { OAUTH_PROVIDERS, APIKEY_PROVIDERS } from "@/shared/constants/config";
const getPageInfo = (pathname) => {
if (!pathname) return { title: "", description: "", breadcrumbs: [] };
@ -73,7 +73,7 @@ export default function Header({ onMenuClick, showMenuButton = true }) {
{breadcrumbs.length > 0 ? (
<div className="flex items-center gap-2">
{breadcrumbs.map((crumb, index) => (
<div key={index} className="flex items-center gap-2">
<div key={`${crumb.label}-${crumb.href || "current"}`} className="flex items-center gap-2">
{index > 0 && (
<span className="material-symbols-outlined text-text-muted text-base">
chevron_right
@ -95,6 +95,7 @@ export default function Header({ onMenuClick, showMenuButton = true }) {
width={28}
height={28}
className="object-contain rounded"
style={{ width: "auto", height: "auto" }}
onError={(e) => { e.currentTarget.style.display = "none"; }}
/>
)}
@ -134,3 +135,8 @@ export default function Header({ onMenuClick, showMenuButton = true }) {
);
}
Header.propTypes = {
onMenuClick: PropTypes.func,
showMenuButton: PropTypes.bool,
};