From 61af8a910cb79e54eec48a0cb52c5997f6306687 Mon Sep 17 00:00:00 2001
From: haritabh-z01 <haritabh.z01+github@gmail.com>
Date: Fri, 12 Sep 2025 01:42:37 +0530
Subject: [PATCH] fix: shortcut validation rules

---
 .../desktop/src/components/shortcut-input.tsx | 32 ++++---------------
 1 file changed, 7 insertions(+), 25 deletions(-)

diff --git a/apps/desktop/src/components/shortcut-input.tsx b/apps/desktop/src/components/shortcut-input.tsx
index 3da3d88..ff18d0f 100644
--- a/apps/desktop/src/components/shortcut-input.tsx
+++ b/apps/desktop/src/components/shortcut-input.tsx
@@ -33,38 +33,20 @@ function validateShortcut(keys: string[]): ValidationResult {
   const modifierKeys = keys.filter((key) => MODIFIER_KEYS.includes(key));
   const regularKeys = keys.filter((key) => !MODIFIER_KEYS.includes(key));
 
-  // Single modifier key (e.g., Fn for PTT)
-  if (keys.length === 1 && modifierKeys.length === 1) {
-    return { valid: true, shortcut: modifierKeys[0] };
-  }
-
-  // Single regular key
+  // disallow only regular keys
   if (modifierKeys.length === 0 && regularKeys.length === 1) {
-    return { valid: true, shortcut: regularKeys[0] };
-  }
-
-  // Modifier(s) + up to 2 regular keys
-  if (
-    modifierKeys.length > 0 &&
-    regularKeys.length > 0 &&
-    regularKeys.length <= 2
-  ) {
-    return {
-      valid: true,
-      shortcut: [...modifierKeys, ...regularKeys].join("+"),
-    };
-  }
-
-  // Multiple regular keys without modifiers
-  if (modifierKeys.length === 0 && regularKeys.length > 1) {
     return {
       valid: false,
       error:
-        "Multiple keys require at least one modifier (Cmd, Win, Ctrl, Alt, Shift, or Fn)",
+        "At least one modifier key (Cmd, Win, Ctrl, Alt, Shift, Fn, etc) is required",
     };
   }
 
-  return { valid: false, error: "Invalid key combination" };
+  if (keys.length > 4) {
+    return { valid: false, error: "Maximum 4 keys allowed" };
+  }
+
+  return { valid: true, shortcut: [...modifierKeys, ...regularKeys].join("+") };
 }
 
 function RecordingDisplay({