Update code-review.md to avoid flagging test failures
This commit is contained in:
parent
1fe9e369a7
commit
2d0fcacc05
1 changed files with 1 additions and 1 deletions
|
|
@ -31,7 +31,7 @@ Examples of false positives, for steps 4 and 5:
|
|||
- Pre-existing issues
|
||||
- Something that looks like a bug but is not actually a bug
|
||||
- Pedantic nitpicks that a senior engineer wouldn't call out
|
||||
- Issues that a linter will catch (no need to run the linter to verify)
|
||||
- Issues that a linter, typechecker, or test runner will catch (eg. failing tests, lint errors, type errors). Do not run these to verify; assume that they will be run as part of CI.
|
||||
- General code quality issues (eg. lack of test coverage, general security issues), unless explicitly required in CLAUDE.md
|
||||
- Issues that are called out in CLAUDE.md, but explicitly silenced in the code (eg. due to a lint ignore comment)
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue