From 09f27d91f14a66f8683dc10ebf8630da16de21a5 Mon Sep 17 00:00:00 2001
From: Lawrence Chen <54008264+lawrencecchen@users.noreply.github.com>
Date: Sun, 8 Feb 2026 17:30:49 -0800
Subject: [PATCH] Revert to npm create-dmg for styled DMG layout

hdiutil produces a basic layout. npm create-dmg (sindresorhus) gives
large centered icons with proper spacing. The blank Applications icon
is a macOS 26 rendering issue that affects both approaches.
---
 .github/workflows/release.yml | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 2cc613d8..b1784208 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -44,7 +44,7 @@ jobs:
         run: |
           brew update
           brew install zig
-          npm uninstall --global create-dmg 2>/dev/null || true
+          npm install --global create-dmg
 
       - name: Build GhosttyKit.xcframework
         run: |
@@ -160,14 +160,12 @@ jobs:
           xcrun stapler validate "$APP_PATH"
           spctl -a -vv --type execute "$APP_PATH"
           rm -f "$ZIP_SUBMIT"
-          # Build DMG with Applications symlink (no Finder/AppleScript needed)
-          DMG_SOURCE="$(mktemp -d)/cmuxterm"
-          mkdir -p "$DMG_SOURCE"
-          cp -R "$APP_PATH" "$DMG_SOURCE/"
-          ln -s /Applications "$DMG_SOURCE/Applications"
-          hdiutil create -volname "cmuxterm" -srcfolder "$DMG_SOURCE" -ov -format UDZO "$DMG_RELEASE"
-          rm -rf "$(dirname "$DMG_SOURCE")"
-          /usr/bin/codesign --force --sign "$APPLE_SIGNING_IDENTITY" "$DMG_RELEASE"
+          # create-dmg generates a styled drag-to-install DMG
+          create-dmg \
+            --identity="$APPLE_SIGNING_IDENTITY" \
+            "$APP_PATH" \
+            ./
+          mv ./cmuxterm*.dmg "$DMG_RELEASE"
           DMG_SUBMIT_JSON="$(xcrun notarytool submit "$DMG_RELEASE" --apple-id "$APPLE_ID" --team-id "$APPLE_TEAM_ID" --password "$APPLE_APP_SPECIFIC_PASSWORD" --wait --output-format json)"
           DMG_SUBMIT_ID="$(python3 -c 'import json,sys; print(json.load(sys.stdin)["id"])' <<<"$DMG_SUBMIT_JSON")"
           DMG_STATUS="$(python3 -c 'import json,sys; print(json.load(sys.stdin)["status"])' <<<"$DMG_SUBMIT_JSON")"