marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1050 from manaflow-ai/issue-1045-drag-hover-terminal-flicker-v2

Browse source 
Fix terminal drag hover overlay flicker
This commit is contained in:
Austin Wang 2026-03-07 12:23:15 -08:00 • committed by GitHub
commit 1fb5e19364
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Sources/GhosttyTerminalView.swift
View file

@ -7030,13 +7030,24 @@ struct GhosttyTerminalView: NSViewRepresentable {
if host.window != nil {
let hostId = ObjectIdentifier(host)
let geometryRevision = host.geometryRevision
let portalEntryMissing = !TerminalWindowPortalRegistry.isHostedView(hostedView, boundTo: host)
let shouldBindNow =
coordinator.lastBoundHostId != hostId ||
hostedView.superview == nil ||
portalEntryMissing ||
previousDesiredIsVisibleInUI != isVisibleInUI ||
previousDesiredShowsUnreadNotificationRing != showsUnreadNotificationRing ||
previousDesiredPortalZPriority != portalZPriority
if shouldBindNow {
#if DEBUG
if portalEntryMissing {
dlog(
"ws.hostState.rebindOnUpdate surface=\(terminalSurface.id.uuidString.prefix(5)) " +
"reason=portalEntryMissing visible=\(coordinator.desiredIsVisibleInUI ? 1 : 0) " +
"active=\(coordinator.desiredIsActive ? 1 : 0) z=\(coordinator.desiredPortalZPriority)"
)
}
#endif
TerminalWindowPortalRegistry.bind(
hostedView: hostedView,
to: host,

2
vendor/bonsplit vendored

@ -1 +1 @@
Subproject commit b1f4916a15c8c7ef6cb2b1401c6af43fbac8708b
Subproject commit fa452db181f361514087558a29204bda7e38218f