marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add devtools hide regression test

Browse source
This commit is contained in:
Lawrence Chen 2026-03-11 20:15:42 -07:00
parent 6272f5082e
commit 46845f2a4f
1 changed files with 43 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

45
cmuxTests/CmuxWebViewKeyEquivalentTests.swift
View file

@ -2522,12 +2522,32 @@ final class BrowserDeveloperToolsVisibilityPersistenceTests: XCTestCase {
}
private final class FakeInspector: NSObject {
enum HideBehavior {
case unsupported
case noEffect
case hides
}
private(set) var attachCount = 0
private(set) var showCount = 0
private(set) var hideCount = 0
private(set) var closeCount = 0
private let hideBehavior: HideBehavior
private var visible = false
private var attached = false
init(hideBehavior: HideBehavior = .unsupported) {
self.hideBehavior = hideBehavior
super.init()
}
override func responds(to aSelector: Selector!) -> Bool {
guard NSStringFromSelector(aSelector) == "hide" else {
return super.responds(to: aSelector)
}
return hideBehavior != .unsupported
}
@objc func isVisible() -> Bool {
visible
}
@ -2547,6 +2567,12 @@ final class BrowserDeveloperToolsVisibilityPersistenceTests: XCTestCase {
visible = true
}
@objc func hide() {
hideCount += 1
guard hideBehavior == .hides else { return }
visible = false
}
@objc func close() {
closeCount += 1
visible = false
@ -2559,9 +2585,11 @@ final class BrowserDeveloperToolsVisibilityPersistenceTests: XCTestCase {
installCmuxUnitTestInspectorOverride()
}
private func makePanelWithInspector() -> (BrowserPanel, FakeInspector) {
private func makePanelWithInspector(
hideBehavior: FakeInspector.HideBehavior = .unsupported
) -> (BrowserPanel, FakeInspector) {
let panel = BrowserPanel(workspaceId: UUID())
let inspector = FakeInspector()
let inspector = FakeInspector(hideBehavior: hideBehavior)
panel.webView.cmuxSetUnitTestInspector(inspector)
return (panel, inspector)
}
@ -2671,6 +2699,19 @@ final class BrowserDeveloperToolsVisibilityPersistenceTests: XCTestCase {
XCTAssertFalse(panel.hasPendingDeveloperToolsRefreshAfterAttach())
}
func testToggleDeveloperToolsFallsBackToCloseWhenHideDoesNotConcealInspector() {
let (panel, inspector) = makePanelWithInspector(hideBehavior: .noEffect)
XCTAssertTrue(panel.showDeveloperTools())
XCTAssertTrue(panel.isDeveloperToolsVisible())
XCTAssertTrue(panel.toggleDeveloperTools())
XCTAssertEqual(inspector.hideCount, 1)
XCTAssertEqual(inspector.closeCount, 1)
XCTAssertFalse(panel.isDeveloperToolsVisible())
}
func testTransientHideAttachmentPreserveFollowsDeveloperToolsIntent() {
let (panel, _) = makePanelWithInspector()