From 63e7cc7faa14083f3d3218d4ab04b270dd7f29ba Mon Sep 17 00:00:00 2001
From: Lawrence Chen <54008264+lawrencecchen@users.noreply.github.com>
Date: Mon, 2 Mar 2026 22:45:22 -0800
Subject: [PATCH] Install ffmpeg via brew for screen recording (#781)

macos-15 GitHub runners don't have ffmpeg pre-installed.
---
 .github/workflows/test-e2e.yml | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml
index bae601dd..82341ae9 100644
--- a/.github/workflows/test-e2e.yml
+++ b/.github/workflows/test-e2e.yml
@@ -97,12 +97,21 @@ jobs:
           echo "=== Display after ==="
           system_profiler SPDisplaysDataType 2>/dev/null || echo "(none)"
 
+      - name: Install ffmpeg
+        if: ${{ inputs.record_video }}
+        run: |
+          brew install --quiet ffmpeg
+          FFMPEG_PATH=$(which ffmpeg)
+          echo "ffmpeg: $FFMPEG_PATH"
+          ffmpeg -version | head -1
+          echo "FFMPEG_PATH=$FFMPEG_PATH" >> "$GITHUB_ENV"
+
       - name: Grant TCC screen recording permission
         continue-on-error: true
         run: |
           TCC_DB="$HOME/Library/Application Support/com.apple.TCC/TCC.db"
           if [ -f "$TCC_DB" ]; then
-            for client in /usr/sbin/screencapture /opt/homebrew/bin/ffmpeg /usr/local/bin/ffmpeg; do
+            for client in /usr/sbin/screencapture "${FFMPEG_PATH:-/opt/homebrew/bin/ffmpeg}" /opt/homebrew/bin/ffmpeg /usr/local/bin/ffmpeg; do
               sqlite3 "$TCC_DB" "INSERT OR REPLACE INTO access (service, client, client_type, auth_value, auth_reason, auth_version) VALUES ('kTCCServiceScreenCapture', '$client', 1, 2, 4, 1);" 2>/dev/null || true
             done
           fi