marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix dark mode icon not applied in automatic mode (#1510)

Browse source 
ensureApplicationIcon() was explicitly loading and setting the light icon
via NSImage(named: NSImage.applicationIconName) even in automatic mode,
overriding the asset catalog's appearance-based icon selection.

Delegate to AppIconSettings.applyIcon() which correctly sets
applicationIconImage = nil for automatic mode, allowing macOS 15+ to
select the dark variant from the asset catalog automatically.

Fixes #1509
Related: #688
This commit is contained in:
ddotz 2026-03-18 09:50:13 +09:00 • committed by GitHub
parent aefb7767f6
commit 6cca8c9264
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Sources/AppDelegate.swift
View file

@ -10260,14 +10260,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCent
private func ensureApplicationIcon() {
let mode = AppIconSettings.resolvedMode()
if mode == .automatic {
// Let the asset catalog handle appearance-based icon selection.
if let icon = NSImage(named: NSImage.applicationIconName) {
NSApplication.shared.applicationIconImage = icon
}
} else {
AppIconSettings.applyIcon(mode)
}
AppIconSettings.applyIcon(mode)
}
private func scheduleLaunchServicesBundleRegistration(