marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: add --direction flag to markdown open command (#1763)

Browse source 
Supports left/right/up/down, defaulting to right (existing behavior).
Matches the --direction flag convention used by new-pane and new-split.
This commit is contained in:
Zachary Salzbank 2026-03-20 04:48:28 -04:00 • committed by GitHub
parent c44e975855
commit 730d64b943
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
CLI/cmux.swift
View file

@ -2358,7 +2358,8 @@ struct CMUXCLI {
let (workspaceOpt, argsAfterWorkspace) = parseOption(args, name: "--workspace")
let (windowOpt, argsAfterWindow) = parseOption(argsAfterWorkspace, name: "--window")
let (surfaceOpt, argsAfterSurface) = parseOption(argsAfterWindow, name: "--surface")
args = argsAfterSurface
let (directionOpt, argsAfterDirection) = parseOption(argsAfterSurface, name: "--direction")
args = argsAfterDirection
// Determine subcommand. Explicit "open" is supported, otherwise treat
// a single positional argument as shorthand path.
@ -2373,7 +2374,7 @@ struct CMUXCLI {
if let first = args.first, first.hasPrefix("-") {
throw CLIError(
message:
"markdown open: unknown flag '\(first)'. Usage: cmux markdown open <path> [--workspace <id|ref|index>] [--surface <id|ref|index>] [--window <id|ref|index>]"
"markdown open: unknown flag '\(first)'. Usage: cmux markdown open <path> [--workspace <id|ref|index>] [--surface <id|ref|index>] [--window <id|ref|index>] [--direction right|down|left|up]"
)
} else if let first = args.first, looksLikePath(first) || first.contains(".") {
subArgs = args
@ -2391,20 +2392,21 @@ struct CMUXCLI {
if let unknownFlag = trailingArgs.first(where: { $0.hasPrefix("-") }) {
throw CLIError(
message:
"markdown open: unknown flag '\(unknownFlag)'. Usage: cmux markdown open <path> [--workspace <id|ref|index>] [--surface <id|ref|index>] [--window <id|ref|index>]"
"markdown open: unknown flag '\(unknownFlag)'. Usage: cmux markdown open <path> [--workspace <id|ref|index>] [--surface <id|ref|index>] [--window <id|ref|index>] [--direction right|down|left|up]"
)
}
if let extraArg = trailingArgs.first {
throw CLIError(
message:
"markdown open: unexpected argument '\(extraArg)'. Usage: cmux markdown open <path> [--workspace <id|ref|index>] [--surface <id|ref|index>] [--window <id|ref|index>]"
"markdown open: unexpected argument '\(extraArg)'. Usage: cmux markdown open <path> [--workspace <id|ref|index>] [--surface <id|ref|index>] [--window <id|ref|index>] [--direction right|down|left|up]"
)
}
let absolutePath = resolvePath(rawPath)
// Build params
var params: [String: Any] = ["path": absolutePath]
let direction = directionOpt ?? "right"
var params: [String: Any] = ["path": absolutePath, "direction": direction]
if let surfaceRaw = surfaceOpt {
if let surface = try normalizeSurfaceHandle(surfaceRaw, client: client) {
params["surface_id"] = surface
@ -7101,11 +7103,13 @@ struct CMUXCLI {
--workspace <id|ref|index> Target workspace (default: $CMUX_WORKSPACE_ID)
--surface <id|ref|index> Source surface to split from (default: focused surface)
--window <id|ref|index> Target window
--direction <left|right|up|down> Split direction (default: right)
Examples:
cmux markdown open plan.md
cmux markdown ~/project/CHANGELOG.md
cmux markdown open ./docs/design.md --workspace 0
cmux markdown open plan.md --direction down
"""
default:
return nil

11
Sources/TerminalController.swift
View file

@ -7158,9 +7158,18 @@ class TerminalController {
let sourcePaneUUID = ws.paneId(forPanelId: sourceSurfaceId)?.id
let directionStr = v2String(params, "direction") ?? "right"
guard let direction = parseSplitDirection(directionStr) else {
result = .err(code: "invalid_params", message: "Invalid direction '\(directionStr)' (left|right|up|down)", data: nil)
return
}
let orientation: SplitOrientation = direction.isHorizontal ? .horizontal : .vertical
let insertFirst = (direction == .left || direction == .up)
let createdPanel = ws.newMarkdownSplit(
from: sourceSurfaceId,
orientation: .horizontal,
orientation: orientation,
insertFirst: insertFirst,
filePath: filePath,
focus: v2FocusAllowed()
)