From 7844226dedacb4575cdcc345f4ef0c62f27c8fab Mon Sep 17 00:00:00 2001 From: Lawrence Chen <54008264+lawrencecchen@users.noreply.github.com> Date: Wed, 11 Mar 2026 20:18:46 -0700 Subject: [PATCH] Fix browser devtools hide fallback --- Sources/Panels/BrowserPanel.swift | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Sources/Panels/BrowserPanel.swift b/Sources/Panels/BrowserPanel.swift index 61daf94e..869bcfe1 100644 --- a/Sources/Panels/BrowserPanel.swift +++ b/Sources/Panels/BrowserPanel.swift @@ -3122,14 +3122,19 @@ extension BrowserPanel { let isVisibleSelector = NSSelectorFromString("isVisible") guard inspector.cmuxCallBool(selector: isVisibleSelector) ?? false else { return true } + var invokedSelector = false for rawSelector in ["hide", "close"] { let selector = NSSelectorFromString(rawSelector) guard inspector.responds(to: selector) else { continue } + invokedSelector = true inspector.cmuxCallVoid(selector: selector) - return true + if !(inspector.cmuxCallBool(selector: isVisibleSelector) ?? false) { + return true + } } - return false + guard invokedSelector else { return false } + return !(inspector.cmuxCallBool(selector: isVisibleSelector) ?? false) } @discardableResult