marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Stabilize browser import menu test flow

Browse source
This commit is contained in:
Lawrence Chen 2026-03-17 02:18:58 -07:00
parent 3c549b4cb8
commit 7bb7564726
No known key found for this signature in database
2 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Sources/cmuxApp.swift
View file

@ -588,7 +588,10 @@ struct cmuxApp: App {
}
Button(String(localized: "menu.view.importFromBrowser", defaultValue: "Import From Browser…")) {
BrowserDataImportCoordinator.shared.presentImportDialog()
// Defer modal presentation until after AppKit finishes menu tracking.
DispatchQueue.main.async {
BrowserDataImportCoordinator.shared.presentImportDialog()
}
}
splitCommandButton(title: String(localized: "menu.view.nextWorkspace", defaultValue: "Next Workspace"), shortcut: nextWorkspaceMenuShortcut) {

10
cmuxUITests/BrowserImportProfilesUITests.swift
View file

@ -123,7 +123,7 @@ final class BrowserImportProfilesUITests: XCTestCase {
let payloadData = try JSONSerialization.data(withJSONObject: payload)
let captureURL = URL(fileURLWithPath: capturePath)
DispatchQueue.main.asyncAfter(deadline: .now() + 0.19) {
DispatchQueue.global(qos: .userInitiated).asyncAfter(deadline: .now() + 0.18) {
try? payloadData.write(to: captureURL)
}
@ -151,10 +151,10 @@ final class BrowserImportProfilesUITests: XCTestCase {
XCTAssertTrue(importItem.waitForExistence(timeout: 5.0), "Expected Import From Browser menu item to exist")
importItem.click()
XCTAssertTrue(
app.staticTexts["Import Browser Data"].waitForExistence(timeout: 5.0),
"Expected the import wizard to open"
)
let wizardOpened = browserImportPollUntil(timeout: 5.0) {
app.buttons["Next"].exists || app.windows["Import Browser Data"].exists
}
XCTAssertTrue(wizardOpened, "Expected the import wizard to open")
}
private func waitForCapturedSelection(timeout: TimeInterval) -> [String: Any]? {