From 8cbb7ea11909649ea808fda7a97fbf65172667eb Mon Sep 17 00:00:00 2001 From: Lawrence Chen <54008264+lawrencecchen@users.noreply.github.com> Date: Sun, 22 Feb 2026 16:18:03 -0800 Subject: [PATCH] Remove terminal overlay static contract CI check --- .github/workflows/ci.yml | 9 ------ scripts/check-terminal-overlay-layering.sh | 36 ---------------------- 2 files changed, 45 deletions(-) delete mode 100755 scripts/check-terminal-overlay-layering.sh diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d004f0a5..9e7bb8bc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,15 +7,6 @@ on: pull_request: jobs: - terminal-overlay-contract: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Enforce terminal overlay layering contract - run: ./scripts/check-terminal-overlay-layering.sh - web-typecheck: runs-on: ubuntu-latest defaults: diff --git a/scripts/check-terminal-overlay-layering.sh b/scripts/check-terminal-overlay-layering.sh deleted file mode 100755 index 6a7e9dde..00000000 --- a/scripts/check-terminal-overlay-layering.sh +++ /dev/null @@ -1,36 +0,0 @@ -#!/usr/bin/env bash -set -euo pipefail - -cd "$(dirname "$0")/.." - -allowed_a="Sources/Find/SurfaceSearchOverlay.swift" -allowed_b="Sources/GhosttyTerminalView.swift" -pattern='SurfaceSearchOverlay[[:space:]]*\(' - -if command -v rg >/dev/null 2>&1; then - matches="$( - rg -n --no-heading --glob '*.swift' "$pattern" Sources cmuxTests \ - | grep -v "^${allowed_a}:" \ - | grep -v "^${allowed_b}:" \ - || true - )" -else - matches="$( - grep -RIn --include='*.swift' -E "$pattern" Sources cmuxTests \ - | grep -v "^${allowed_a}:" \ - | grep -v "^${allowed_b}:" \ - || true - )" -fi - -if [[ -n "$matches" ]]; then - echo "Terminal overlay layering contract violation:" - echo "SurfaceSearchOverlay may only be instantiated in:" - echo " - ${allowed_a}" - echo " - ${allowed_b}" - echo - echo "$matches" - exit 1 -fi - -echo "OK: terminal overlay layering contract satisfied."