From 915e34bd38bc4c698452f2a7d1e6425bde3e271f Mon Sep 17 00:00:00 2001 From: Lawrence Chen <54008264+lawrencecchen@users.noreply.github.com> Date: Wed, 18 Feb 2026 20:37:59 -0800 Subject: [PATCH] Revert xcframework-target removal that broke CI (#86) (#90) The -Dxcframework-target flag controls platform slices (native=macOS only, universal=macOS+iOS), not CPU microarchitecture. Removing it caused CI to attempt iOS builds which fail due to missing Metal iOS toolchain on the runner. --- .github/workflows/ci.yml | 2 +- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 943b789d..78c04c03 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -69,7 +69,7 @@ jobs: exit 1 fi fi - (cd ghostty && zig build -Demit-xcframework=true -Demit-macos-app=false) + (cd ghostty && zig build -Demit-xcframework=true -Demit-macos-app=false -Dxcframework-target=native) rm -rf GhosttyKit.xcframework cp -R ghostty/macos/GhosttyKit.xcframework GhosttyKit.xcframework test -d GhosttyKit.xcframework diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4cbcb8dd..381e955b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -52,7 +52,7 @@ jobs: - name: Build GhosttyKit.xcframework run: | cd ghostty - zig build -Demit-xcframework=true -Demit-macos-app=false -Doptimize=ReleaseFast + zig build -Demit-xcframework=true -Demit-macos-app=false -Dxcframework-target=native -Doptimize=ReleaseFast cd .. rm -rf GhosttyKit.xcframework cp -R ghostty/macos/GhosttyKit.xcframework GhosttyKit.xcframework