marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1415 from manaflow-ai/task-throttle-socket-listener-start-failures

Browse source 
Throttle repeated socket listener start failures
This commit is contained in:
Lawrence Chen 2026-03-13 20:02:56 -07:00 • committed by GitHub
commit 919c9b1632
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 29 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Sources/TerminalController.swift
View file

@ -60,6 +60,9 @@ class TerminalController {
private nonisolated static let socketProbePollTimeoutMs: Int32 = 100
private nonisolated static let socketProbePollAttempts = 3
private nonisolated static let socketProbePollRetryBackoffUs: useconds_t = 50_000
private nonisolated static let socketListenerFailureCaptureCooldown: TimeInterval = 60
private nonisolated static let socketListenerFailureCaptureLock = NSLock()
private nonisolated(unsafe) static var socketListenerFailureLastCapturedAt: [String: Date] = [:]
private nonisolated static let unixSocketPathMaxLength: Int = {
var addr = sockaddr_un()
// Reserve one byte for the null terminator.
@ -505,9 +508,35 @@ class TerminalController {
) {
let data = socketListenerEventData(stage: stage, errnoCode: errnoCode, extra: extra)
sentryBreadcrumb(message, category: "socket", data: data)
guard Self.shouldCaptureSocketListenerFailure(
message: message,
stage: stage,
path: data["path"] as? String ?? "",
errnoCode: errnoCode
) else {
return
}
sentryCaptureError(message, category: "socket", data: data, contextKey: "socket_listener")
}
private nonisolated static func shouldCaptureSocketListenerFailure(
message: String,
stage: String,
path: String,
errnoCode: Int32?
) -> Bool {
let key = "\(message)|\(stage)|\(path)|\(errnoCode.map(String.init) ?? "none")"
let now = Date()
socketListenerFailureCaptureLock.lock()
defer { socketListenerFailureCaptureLock.unlock() }
if let lastCapturedAt = socketListenerFailureLastCapturedAt[key],
now.timeIntervalSince(lastCapturedAt) < socketListenerFailureCaptureCooldown {
return false
}
socketListenerFailureLastCapturedAt[key] = now
return true
}
nonisolated static func acceptErrorClassification(errnoCode: Int32) -> String {
switch errnoCode {
case EINTR, ECONNABORTED, EAGAIN, EWOULDBLOCK: