marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Keep localhost visible in SSH omnibar URLs

Browse source 
Remote loopback requests still route through the localtest.me alias for proxy transport, but the omnibar now canonicalizes the alias host back to localhost for display.
This commit is contained in:
Lawrence Chen 2026-03-01 21:29:14 -08:00
parent 0d3d71661d
commit 944d337fcf
1 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Sources/Panels/BrowserPanel.swift
View file

@ -1658,6 +1658,16 @@ final class BrowserPanel: Panel, ObservableObject {
return components?.url ?? url
}
private func canonicalLoopbackURLForDisplayIfNeeded(_ url: URL) -> URL {
guard remoteProxyEndpoint != nil else { return url }
guard let host = BrowserInsecureHTTPSettings.normalizeHost(url.host ?? "") else { return url }
guard host == Self.remoteLoopbackProxyAliasHost else { return url }
var components = URLComponents(url: url, resolvingAgainstBaseURL: false)
components?.host = "localhost"
return components?.url ?? url
}
private func preparedNavigationRequest(_ request: URLRequest) -> URLRequest {
var prepared = browserPreparedNavigationRequest(request)
guard let url = prepared.url else { return prepared }
@ -2608,14 +2618,18 @@ extension BrowserPanel {
/// Returns the most reliable URL string for omnibar-related matching and UI decisions.
/// `currentURL` can lag behind navigation changes, so prefer the live WKWebView URL.
func preferredURLStringForOmnibar() -> String? {
if let webViewURL = webView.url?.absoluteString
if let webViewURL = webView.url
.map(canonicalLoopbackURLForDisplayIfNeeded)?
.absoluteString
.trimmingCharacters(in: .whitespacesAndNewlines),
!webViewURL.isEmpty,
webViewURL != blankURLString {
return webViewURL
}
if let current = currentURL?.absoluteString
if let current = currentURL
.map(canonicalLoopbackURLForDisplayIfNeeded)?
.absoluteString
.trimmingCharacters(in: .whitespacesAndNewlines),
!current.isEmpty,
current != blankURLString {