fix: guard inherited terminal config against stale surfaces (#2101)

* test: add stale inherited surface regression

* fix: guard inherited terminal config against stale surfaces

* fix: address stale surface review feedback
This commit is contained in:
Austin Wang 2026-03-25 16:49:54 -07:00 committed by GitHub
parent 99ca3c9b9a
commit 9f2adce830
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 253 additions and 21 deletions

View file

@ -2216,8 +2216,9 @@ class TabManager: ObservableObject {
workspace: Workspace?
) -> ghostty_surface_config_s? {
if let panel = terminalPanelForWorkspaceConfigInheritanceSource(workspace: workspace),
panel.surface.hasLiveSurface,
let sourceSurface = panel.surface.surface {
let sourceSurface = panel.surface.liveSurfaceForGhosttyAccess(
reason: "tabManager.inheritedTerminalConfigForNewWorkspace"
) {
return cmuxInheritedSurfaceConfig(
sourceSurface: sourceSurface,
context: GHOSTTY_SURFACE_CONTEXT_TAB