marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add failing regression test for browser find focus (#1891)

Browse source 
* test: add browser find focus regression

* ci: run browser find focus regression on prs

* ci: merge pr ui regressions into one job

* fix: focus browser find after navigation

* test: rename ui regressions workflow guard

* Fix browser find focus after address bar navigation

* Fix test-e2e workflow manifest script

* Address PR review feedback

* Stabilize browser focus regression on CI

---------

Co-authored-by: Lawrence Chen <lawrencecchen@users.noreply.github.com>
This commit is contained in:
Lawrence Chen 2026-03-20 22:12:26 -07:00 • committed by GitHub
parent c2065b135d
commit a592ed126a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 331 additions and 108 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Sources/AppDelegate.swift
View file

@ -12473,6 +12473,13 @@ private extension NSWindow {
in window: NSWindow,
event: NSEvent?
) -> CmuxWebView? {
// Browser find runs in the portal slot alongside the hosted WKWebView.
// Treat its native field editor chain as browser chrome, not as web content,
// so Cmd+F can move first responder into the find field while web focus is suppressed.
if BrowserWindowPortalRegistry.searchOverlayPanelId(for: responder, in: window) != nil {
return nil
}
if let webView = cmuxOwningWebView(for: responder) {
return webView
}