marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(terminal): address vim badge review notes

Browse source
This commit is contained in:
Brian Le 2026-03-09 00:53:42 -04:00
parent ad8c57432c
commit c3a8c2317f
No known key found for this signature in database
1 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Sources/GhosttyTerminalView.swift
View file

@ -4442,12 +4442,14 @@ class GhosttyNSView: NSView, NSUserInterfaceValidations {
case GHOSTTY_KEY_TABLE_ACTIVATE:
let namePtr = action.value.activate.name
let nameLen = Int(action.value.activate.len)
let name: String
if let namePtr, nameLen > 0 {
let data = Data(bytes: namePtr, count: nameLen)
if let name = String(data: data, encoding: .utf8) {
keyTables.append(name)
}
name = String(data: data, encoding: .utf8) ?? ""
} else {
name = ""
}
keyTables.append(name)
case GHOSTTY_KEY_TABLE_DEACTIVATE:
_ = keyTables.popLast()
case GHOSTTY_KEY_TABLE_DEACTIVATE_ALL:
@ -4958,7 +4960,7 @@ final class GhosttySurfaceScrollView: NSView {
private let notificationRingLayer: CAShapeLayer
private let flashOverlayView: GhosttyFlashOverlayView
private let flashLayer: CAShapeLayer
private let keyboardCopyModeBadgeContainerView: GhosttyPassthroughVisualEffectView
private let keyboardCopyModeBadgeContainerView: GhosttyFlashOverlayView
private let keyboardCopyModeBadgeView: GhosttyPassthroughVisualEffectView
private let keyboardCopyModeBadgeIconView: NSImageView
private let keyboardCopyModeBadgeLabel: NSTextField
@ -5128,7 +5130,7 @@ final class GhosttySurfaceScrollView: NSView {
notificationRingLayer = CAShapeLayer()
flashOverlayView = GhosttyFlashOverlayView(frame: .zero)
flashLayer = CAShapeLayer()
keyboardCopyModeBadgeContainerView = GhosttyPassthroughVisualEffectView(frame: .zero)
keyboardCopyModeBadgeContainerView = GhosttyFlashOverlayView(frame: .zero)
keyboardCopyModeBadgeView = GhosttyPassthroughVisualEffectView(frame: .zero)
keyboardCopyModeBadgeIconView = NSImageView(frame: .zero)
keyboardCopyModeBadgeLabel = NSTextField(labelWithString: terminalKeyboardCopyModeIndicatorText)
@ -5206,9 +5208,6 @@ final class GhosttySurfaceScrollView: NSView {
addSubview(flashOverlayView)
keyboardCopyModeBadgeContainerView.translatesAutoresizingMaskIntoConstraints = false
keyboardCopyModeBadgeContainerView.wantsLayer = true
keyboardCopyModeBadgeContainerView.material = .hudWindow
keyboardCopyModeBadgeContainerView.blendingMode = .withinWindow
keyboardCopyModeBadgeContainerView.state = .active
keyboardCopyModeBadgeContainerView.layer?.masksToBounds = false
keyboardCopyModeBadgeContainerView.layer?.shadowColor = NSColor.black.cgColor
keyboardCopyModeBadgeContainerView.layer?.shadowOpacity = 0.22