From cef1513ceb2778e151a772fb1ea53615d1f0dadc Mon Sep 17 00:00:00 2001 From: Lawrence Chen <54008264+lawrencecchen@users.noreply.github.com> Date: Thu, 19 Feb 2026 22:46:17 -0800 Subject: [PATCH] Fix notification ring not appearing on terminal panes TerminalPanelView and PanelContentView held notificationStore as a plain `let` property. Since it's a reference type (class), SwiftUI's structural diffing saw no change when notifications were added and skipped re-evaluating the view body. Changed to @ObservedObject var so the views properly subscribe to the store's @Published changes. Closes #126 --- Sources/Panels/PanelContentView.swift | 2 +- Sources/Panels/TerminalPanelView.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Sources/Panels/PanelContentView.swift b/Sources/Panels/PanelContentView.swift index 9049e166..579614a3 100644 --- a/Sources/Panels/PanelContentView.swift +++ b/Sources/Panels/PanelContentView.swift @@ -10,7 +10,7 @@ struct PanelContentView: View { let portalPriority: Int let isSplit: Bool let appearance: PanelAppearance - let notificationStore: TerminalNotificationStore + @ObservedObject var notificationStore: TerminalNotificationStore let onFocus: () -> Void let onRequestPanelFocus: () -> Void let onTriggerFlash: () -> Void diff --git a/Sources/Panels/TerminalPanelView.swift b/Sources/Panels/TerminalPanelView.swift index 4486d724..2f3f2b51 100644 --- a/Sources/Panels/TerminalPanelView.swift +++ b/Sources/Panels/TerminalPanelView.swift @@ -10,7 +10,7 @@ struct TerminalPanelView: View { let portalPriority: Int let isSplit: Bool let appearance: PanelAppearance - let notificationStore: TerminalNotificationStore + @ObservedObject var notificationStore: TerminalNotificationStore let onFocus: () -> Void let onTriggerFlash: () -> Void