marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add pinned workspace close regression tests

Browse source
This commit is contained in:
austinpower1258 2026-03-20 19:27:37 -07:00
parent 39c03c9b07
commit d219a41dd0
2 changed files with 64 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

38
cmuxTests/TerminalControllerSocketSecurityTests.swift
View file

@ -216,6 +216,44 @@ final class TerminalControllerSocketSecurityTests: XCTestCase {
XCTAssertFalse(store.hasUnreadNotification(forTabId: workspace.id, surfaceId: focusedPanelId))
}
func testWorkspaceCloseRejectsPinnedWorkspace() async throws {
let socketPath = makeSocketPath("close-pinned")
let manager = TabManager()
let pinnedWorkspace = manager.addWorkspace(select: false)
manager.setPinned(pinnedWorkspace, pinned: true)
TerminalController.shared.start(
tabManager: manager,
socketPath: socketPath,
accessMode: .allowAll
)
try waitForSocket(at: socketPath)
let response = try await withCheckedThrowingContinuation { continuation in
DispatchQueue.global(qos: .userInitiated).async {
do {
let response = try self.sendV2Request(
method: "workspace.close",
params: ["workspace_id": pinnedWorkspace.id.uuidString],
to: socketPath
)
continuation.resume(returning: response)
} catch {
continuation.resume(throwing: error)
}
}
}
XCTAssertEqual(response["ok"] as? Bool, false, "Unexpected JSON-RPC response: \(response)")
let error = try XCTUnwrap(response["error"] as? [String: Any], "Unexpected JSON-RPC response: \(response)")
XCTAssertEqual(error["code"] as? String, "protected")
let data = try XCTUnwrap(error["data"] as? [String: Any], "Expected error data payload")
XCTAssertEqual(data["workspace_id"] as? String, pinnedWorkspace.id.uuidString)
XCTAssertEqual(data["pinned"] as? Bool, true)
XCTAssertTrue(manager.tabs.contains(where: { $0.id == pinnedWorkspace.id }))
}
private func waitForSocket(at path: String, timeout: TimeInterval = 2.0) throws {
let expectation = XCTNSPredicateExpectation(
predicate: NSPredicate { _, _ in