marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bump version to 1.19.1 (#23)

Browse source
This commit is contained in:
Lawrence Chen 2026-02-08 17:04:31 -08:00 • committed by GitHub
parent 29658c18ae
commit d2ecfc4342
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 92 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

81
Sources/Update/UpdatePopoverView.swift
View file

@ -337,6 +337,11 @@ fileprivate struct UpdateErrorView: View {
let error: UpdateState.Error
let dismiss: DismissAction
private var isLocationError: Bool {
let nsError = error.error as NSError
return nsError.domain == SUSparkleErrorDomain && (nsError.code == 1003 || nsError.code == 1005)
}
var body: some View {
let title = UpdateViewModel.userFacingErrorTitle(for: error.error)
let message = UpdateViewModel.userFacingErrorMessage(for: error.error)
@ -349,8 +354,8 @@ fileprivate struct UpdateErrorView: View {
VStack(alignment: .leading, spacing: 16) {
VStack(alignment: .leading, spacing: 8) {
HStack(spacing: 8) {
Image(systemName: "exclamationmark.triangle.fill")
.foregroundColor(.orange)
Image(systemName: isLocationError ? "arrow.right.doc.on.clipboard" : "exclamationmark.triangle.fill")
.foregroundColor(isLocationError ? .accentColor : .orange)
.font(.system(size: 13))
Text(title)
.font(.system(size: 13, weight: .semibold))
@ -362,39 +367,57 @@ fileprivate struct UpdateErrorView: View {
.fixedSize(horizontal: false, vertical: true)
}
VStack(alignment: .leading, spacing: 6) {
Text("Details")
.font(.system(size: 11, weight: .semibold))
Text(details)
.font(.system(size: 10, design: .monospaced))
.foregroundColor(.secondary)
.fixedSize(horizontal: false, vertical: true)
.textSelection(.enabled)
}
if isLocationError {
HStack(spacing: 8) {
Button("Open Applications Folder") {
NSWorkspace.shared.selectFile(nil, inFileViewerRootedAtPath: "/Applications")
}
.controlSize(.small)
HStack(spacing: 8) {
Button("Copy Details") {
let pasteboard = NSPasteboard.general
pasteboard.clearContents()
pasteboard.setString(details, forType: .string)
Spacer()
Button("OK") {
error.dismiss()
dismiss()
}
.keyboardShortcut(.defaultAction)
.controlSize(.small)
}
.controlSize(.small)
Button("OK") {
error.dismiss()
dismiss()
} else {
VStack(alignment: .leading, spacing: 6) {
Text("Details")
.font(.system(size: 11, weight: .semibold))
Text(details)
.font(.system(size: 10, design: .monospaced))
.foregroundColor(.secondary)
.fixedSize(horizontal: false, vertical: true)
.textSelection(.enabled)
}
.keyboardShortcut(.cancelAction)
.controlSize(.small)
Spacer()
HStack(spacing: 8) {
Button("Copy Details") {
let pasteboard = NSPasteboard.general
pasteboard.clearContents()
pasteboard.setString(details, forType: .string)
}
.controlSize(.small)
Button("Retry") {
error.retry()
dismiss()
Button("OK") {
error.dismiss()
dismiss()
}
.keyboardShortcut(.cancelAction)
.controlSize(.small)
Spacer()
Button("Retry") {
error.retry()
dismiss()
}
.keyboardShortcut(.defaultAction)
.controlSize(.small)
}
.keyboardShortcut(.defaultAction)
.controlSize(.small)
}
}
.padding(16)

2
Sources/Update/UpdateViewModel.swift
View file

@ -205,7 +205,7 @@ class UpdateViewModel: ObservableObject {
case 1, 2, 3001, 3002:
return "Update Signature Error"
case 1003, 1005:
return "App Location Issue"
return "Move to Applications"
default:
break
}