marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Portal: hide terminal view before hidden-frame updates

Browse source
This commit is contained in:
Lawrence Chen 2026-02-23 05:54:02 -08:00
parent 5070b137a4
commit df779d32ea
1 changed files with 21 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Sources/TerminalWindowPortal.swift
View file

@ -870,6 +870,22 @@ final class WindowTerminalPortal: NSObject {
)
}
#endif
// Hide before updating the frame when this entry should not be visible.
// This avoids a one-frame flash of unrendered terminal background when a portal
// briefly transitions through offscreen/tiny geometry during rapid split churn.
if shouldHide, !hostedView.isHidden {
#if DEBUG
dlog(
"portal.hidden hosted=\(portalDebugToken(hostedView)) value=1 " +
"visibleInUI=\(entry.visibleInUI ? 1 : 0) anchorHidden=\(anchorHidden ? 1 : 0) " +
"tiny=\(tinyFrame ? 1 : 0) finite=\(hasFiniteFrame ? 1 : 0) " +
"outside=\(outsideHostBounds ? 1 : 0) frame=\(portalDebugFrame(frameInHost))"
)
#endif
hostedView.isHidden = true
}
if !Self.rectApproximatelyEqual(oldFrame, frameInHost) {
CATransaction.begin()
CATransaction.setDisableActions(true)
@ -877,21 +893,22 @@ final class WindowTerminalPortal: NSObject {
CATransaction.commit()
if abs(oldFrame.size.width - frameInHost.size.width) > 0.5 ||
abs(oldFrame.size.height - frameInHost.size.height) > 0.5 {
abs(oldFrame.size.height - frameInHost.size.height) > 0.5,
!shouldHide {
hostedView.reconcileGeometryNow()
}
}
if hostedView.isHidden != shouldHide {
if !shouldHide, hostedView.isHidden {
#if DEBUG
dlog(
"portal.hidden hosted=\(portalDebugToken(hostedView)) value=\(shouldHide ? 1 : 0) " +
"portal.hidden hosted=\(portalDebugToken(hostedView)) value=0 " +
"visibleInUI=\(entry.visibleInUI ? 1 : 0) anchorHidden=\(anchorHidden ? 1 : 0) " +
"tiny=\(tinyFrame ? 1 : 0) finite=\(hasFiniteFrame ? 1 : 0) " +
"outside=\(outsideHostBounds ? 1 : 0) frame=\(portalDebugFrame(frameInHost))"
)
#endif
hostedView.isHidden = shouldHide
hostedView.isHidden = false
}
ensureDividerOverlayOnTop()