From f0dcdf90e9ec9b96edb5cafb7039d9348cbbee94 Mon Sep 17 00:00:00 2001
From: austinpower1258 <austinwang115@gmail.com>
Date: Fri, 20 Mar 2026 23:06:44 -0700
Subject: [PATCH] test: cover first-click Sparkle dialog regression

---
 cmuxUITests/SidebarHelpMenuUITests.swift | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/cmuxUITests/SidebarHelpMenuUITests.swift b/cmuxUITests/SidebarHelpMenuUITests.swift
index 9f7aa5e6..5c9bb7b0 100644
--- a/cmuxUITests/SidebarHelpMenuUITests.swift
+++ b/cmuxUITests/SidebarHelpMenuUITests.swift
@@ -47,12 +47,12 @@ final class SidebarHelpMenuUITests: XCTestCase {
         XCTAssertTrue(app.staticTexts["ShortcutRecordingHint"].waitForExistence(timeout: 6.0))
     }
 
-    func testHelpMenuCheckForUpdatesTriggersSidebarUpdatePill() {
+    func testHelpMenuCheckForUpdatesShowsSparkleDialogOnFirstAttempt() {
         let app = XCUIApplication()
         app.launchEnvironment["CMUX_UI_TEST_MODE"] = "1"
         app.launchEnvironment["CMUX_UI_TEST_FEED_URL"] = "https://cmux.test/appcast.xml"
         app.launchEnvironment["CMUX_UI_TEST_FEED_MODE"] = "available"
-        app.launchEnvironment["CMUX_UI_TEST_UPDATE_VERSION"] = "9.9.9"
+        app.launchEnvironment["CMUX_UI_TEST_UPDATE_VERSION"] = "99.0.0"
         app.launchEnvironment["CMUX_UI_TEST_AUTO_ALLOW_PERMISSION"] = "1"
         launchAndActivate(app)
 
@@ -72,9 +72,11 @@ final class SidebarHelpMenuUITests: XCTestCase {
         )
         checkForUpdatesItem.click()
 
-        let updatePill = app.buttons["UpdatePill"]
-        XCTAssertTrue(updatePill.waitForExistence(timeout: 6.0))
-        XCTAssertEqual(updatePill.label, "Update Available: 9.9.9")
+        let installButton = app.buttons["Install Update"]
+        XCTAssertTrue(installButton.waitForExistence(timeout: 8.0))
+        XCTAssertTrue(app.buttons["Remind Me Later"].exists)
+        XCTAssertTrue(app.buttons["Skip This Version"].exists)
+        XCTAssertTrue(app.staticTexts["99.0.0"].exists)
     }
 
     func testHelpMenuSendFeedbackOpensComposerSheet() {