Commit graph

508 commits

Author SHA1 Message Date
Amar Sood (tekacs)
c74479d0b4 Fix window title updates applying to wrong window
TabManager.updateWindowTitle() used NSApp.keyWindow to find the target
window, meaning any terminal title change (e.g. a spinner) would update
whichever window happened to be focused, not the window that owns that
TabManager. This corrupted the macOS Accessibility title attribute and
caused visible title flapping in multi-window setups.

Add a weak back-reference from TabManager to its owning NSWindow, set
by AppDelegate.registerMainWindow(), and use it instead of keyWindow.
2026-02-24 14:35:09 -08:00
Lawrence Chen
06cd25ed52 Fix session restore routing and browser history persistence 2026-02-24 14:34:55 -08:00
Lawrence Chen
aa222dbc0d Sidebar double-click appends workspace to end 2026-02-24 14:32:56 -08:00
Austin Wang
79034540f9
Merge pull request #439 from manaflow-ai/cmux/terminal-fails-to-load-render-split
Fix terminal render recovery after split topology churn
2026-02-24 14:24:47 -08:00
Lawrence Chen
653c59a90b
Merge pull request #437 from manaflow-ai/task-sidebar-selected-workspace-colors
Sidebar: set selected workspace colors and white text
2026-02-24 14:24:46 -08:00
Lawrence Chen
aeda5f827d Adopt custom blue accent across active UI states 2026-02-24 14:22:58 -08:00
Austin Wang
1f7f5de6ce
Merge pull request #438 from manaflow-ai/cmux/titlebar-issues
Fix sidebar titlebar drag and double-click passthrough
2026-02-24 14:20:57 -08:00
austinpower1258
98cf07ce2a Stabilize terminal render recovery after split topology churn 2026-02-24 14:20:14 -08:00
austinpower1258
e76de71f3e Fix sidebar titlebar drag and double-click passthrough 2026-02-24 14:18:58 -08:00
Lawrence Chen
2338760186 Set selected sidebar workspace colors and white text 2026-02-24 14:12:15 -08:00
Lawrence Chen
ecd7f497c8
Merge pull request #436 from manaflow-ai/task-browser-ui-invisible-light-system-dark-ghostty
Fix invisible browser chrome in mixed light/dark themes
2026-02-24 14:11:42 -08:00
Austin Wang
6b99792f51
Merge pull request #434 from manaflow-ai/cmux/issues
Fix browser Return/Enter keyDown routing for web views
2026-02-24 14:06:01 -08:00
Lawrence Chen
c56ef67750 Fix browser chrome contrast for mixed light/dark themes 2026-02-24 14:05:45 -08:00
Lawrence Chen
0516bcb877 Merge remote-tracking branch 'origin/main' into pr-425 2026-02-24 13:58:32 -08:00
austinpower1258
5dc2d8d800 wip 2026-02-24 13:54:52 -08:00
Austin Wang
2da5070782
Merge pull request #428 from manaflow-ai/cmux/issues
Fix browser Return/Enter submission and add enter tracing
2026-02-24 00:12:53 -08:00
austinpower1258
e510bf2d17 Remove temporary Enter tracing instrumentation 2026-02-24 00:09:53 -08:00
Lawrence Chen
6a3c0bd6f4
Merge pull request #419 from manaflow-ai/task-bonsplit-tab-drag-lag-debug-logging
Add debug timing logs for bonsplit tab transfer lag repro
2026-02-23 23:59:01 -08:00
austinpower1258
7d59e550bc Fix browser Return/Enter routing and add enter trace logs 2026-02-23 23:57:13 -08:00
Lawrence Chen
cd03073240 Fix tab drag blank state and preserve non-custom titles across window drops 2026-02-23 23:57:09 -08:00
Lawrence Chen
1893fc4c7a
Use native WebKit middle-click handling for browser links (#416)
* Add middle-click debug logging for browser links

* Handle browser middle-click via native WebKit actions

* Fix flaky middle-click new-tab detection in browser
2026-02-23 23:09:36 -08:00
Amar Sood (tekacs)
3d592fb09a Fix window title updates applying to wrong window
TabManager.updateWindowTitle() used NSApp.keyWindow to find the target
window, meaning any terminal title change (e.g. a spinner) would update
whichever window happened to be focused, not the window that owns that
TabManager. This corrupted the macOS Accessibility title attribute and
caused visible title flapping in multi-window setups.

Add a weak back-reference from TabManager to its owning NSWindow, set
by AppDelegate.registerMainWindow(), and use it instead of keyWindow.
2026-02-23 23:47:25 -05:00
austinpower1258
b0d86a4f0d Fix double-click titlebar zoom not working on browser panel side
The browser portal's hit-test was intercepting clicks in the titlebar
region, preventing double-click-to-zoom from reaching the window.

Three fixes:
- BrowserWindowPortal: pass through hits landing in the native titlebar
- WindowDragHandleView: only let titlebar-overlay views block capture,
  not underlay browser content; respect AppleActionOnDoubleClick pref
- ContentView: use shared performStandardTitlebarDoubleClick() helper

Closes https://github.com/manaflow-ai/cmux/issues/422

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-23 20:45:25 -08:00
Lawrence Chen
fb1802a54d Guard terminal onFocus from re-entrant focus loops 2026-02-23 20:20:55 -08:00
Lawrence Chen
3c1650d3e0
Fix Cmd+P/Cmd+Shift+P window routing (#413)
* Fix command palette shortcuts to stay window-scoped

* Fix cross-window command palette typing focus lock
2026-02-23 20:08:21 -08:00
Lawrence Chen
a97e0edea8 Add drag transfer timing logs for bonsplit tabs 2026-02-23 20:05:12 -08:00
austinpower1258
e5448ac48a Fix stuck titlebar drag suppression 2026-02-23 20:00:47 -08:00
austinpower1258
8f94fd0f50 Fix stale browser favicon after navigation 2026-02-23 20:00:47 -08:00
Lawrence Chen
1c3f8458ee Clear stale surface bg override on config changes 2026-02-23 19:54:54 -08:00
Lawrence Chen
66a9435da6 Add background source diagnostics for theme sync 2026-02-23 19:52:01 -08:00
Lawrence Chen
5c65e25b66 Reassert destination focus after cross-window tab moves 2026-02-23 19:50:09 -08:00
Lawrence Chen
a90e0a739e Keep focus on destination after cross-window surface move 2026-02-23 19:50:09 -08:00
Lawrence Chen
8736421e8c Prevent stale host visibility thrash after tab move 2026-02-23 19:50:09 -08:00
Lawrence Chen
946b0f28e6 Fix theme bg sync on appearance changes 2026-02-23 19:48:55 -08:00
Lawrence Chen
2c2190b231 Block tab drags across cmux app instances 2026-02-23 19:48:54 -08:00
Lawrence Chen
d8022db404 Handle moving the last surface out of a window 2026-02-23 19:48:54 -08:00
Lawrence Chen
b57087f796 Implement cross-window tab and workspace move UI 2026-02-23 19:48:54 -08:00
Lawrence Chen
5f38178f85
Merge pull request #408 from manaflow-ai/issue-407-focus-swap-omnibar-command-palette
Fix omnibar/command-palette focus oscillation
2026-02-23 19:31:17 -08:00
Lawrence Chen
89756bad65 Fix command palette caret color in light mode 2026-02-23 19:28:48 -08:00
Lawrence Chen
78d1a43733 Persist workspace tab colors across session restore 2026-02-23 19:27:32 -08:00
Lawrence Chen
666ef75d1e Fix light-mode typing indicator contrast in active sidebar 2026-02-23 19:22:39 -08:00
Lawrence Chen
ea33e3adbd Merge remote-tracking branch 'origin/main' into pr-317-session-persistence
# Conflicts:
#	Sources/AppDelegate.swift
2026-02-23 19:20:56 -08:00
Lawrence Chen
0dee878268 Fix light-mode sidebar typing indicator contrast 2026-02-23 19:14:32 -08:00
Lawrence Chen
011abb62c9 Refine command palette focus restore and shortcut gating 2026-02-23 19:10:02 -08:00
Lawrence Chen
05101a1a10 Fix light theme omnibar suggestions popover styling 2026-02-23 19:06:50 -08:00
Lawrence Chen
88c1dbc5d6 Fix omnibar focus thrash when another text field takes focus 2026-02-23 19:00:01 -08:00
Lawrence Chen
82ef5b8f6e Move omnibar suggestions popover up 1px 2026-02-23 18:51:32 -08:00
Lawrence Chen
b87d4fecda Move omnibar suggestions popover up by 2px 2026-02-23 18:43:39 -08:00
Lawrence Chen
ed0dd1ccb7 Make omnibar suggestions popup/rows squircle 2026-02-23 18:39:58 -08:00
Lawrence Chen
4e455a185c
Merge pull request #398 from manaflow-ai/task-light-mode-browser-omnibar-theme-bg
Fix light-mode browser omnibar chrome background
2026-02-23 18:25:55 -08:00