Commit graph

662 commits

Author SHA1 Message Date
Lawrence Chen
b268b2fc8f Fix command palette async search review issues 2026-03-06 03:42:37 -08:00
Lawrence Chen
2c2da79138 Merge origin/main into issue-668-command-palette-search-speed 2026-03-06 03:36:39 -08:00
Lawrence Chen
6a319bec8c
Move update logs into Debug menu (#1008)
Move "Copy Update Logs" and "Copy Focus Logs" from a standalone
top-level "Update Logs" menu into the existing Debug menu. Remove
the now-unused menu.updateLogs.title localization key.

Co-authored-by: cmux <cmux@cmuxs-Mac-mini.local>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-06 01:03:38 -08:00
Lawrence Chen
661cb99da6 Tighten command palette search cache keys 2026-03-06 01:01:18 -08:00
Lawrence Chen
d8ffb3eedb
Merge pull request #932 from manaflow-ai/issue-922-notify-steals-window-focus
Fix cmux notify focus steal regression
2026-03-06 00:51:47 -08:00
Austin Wang
0588aec593
Revert "ok (#717)"
This reverts commit a3681ede5b.
2026-03-06 00:19:28 -08:00
Austin Wang
0f14fc0cd1
Merge pull request #995 from manaflow-ai/issue-969-browser-drag-top-drop-targets
Fix browser portal anchor churn during pane drag
2026-03-06 00:18:18 -08:00
Austin Wang
380fc081f5
Merge pull request #987 from manaflow-ai/issue-915-terminal-not-loaded
Refresh background workspace git metadata after external checkout
2026-03-05 23:14:12 -08:00
austinpower1258
0285cd1f51 Address PR review feedback 2026-03-05 23:09:45 -08:00
Lawrence Chen
5041796eb2
Polish feedback help menu copy (#1003) 2026-03-05 22:58:49 -08:00
Lawrence Chen
6993c8ceef Allow notify_target across windows 2026-03-05 22:53:37 -08:00
Lawrence Chen
ae4781ef66 Prepare notify regression source terminal in app setup 2026-03-05 22:39:26 -08:00
Lawrence Chen
e04787789e
Fix markdown panel text click focus (#991)
* Add markdown click regression test

* Fix markdown panel click focus

* Preserve markdown text selection

* Make markdown observer tests deterministic
2026-03-05 22:38:10 -08:00
austinpower1258
3874cac08e Merge origin/main into issue-969-browser-drag-top-drop-targets 2026-03-05 22:36:33 -08:00
austinpower1258
6d95044355 Hide stale browser portals during workspace handoff 2026-03-05 22:32:16 -08:00
Lawrence Chen
46e810fef2
Move rectApproximatelyEqual out of #if DEBUG in HostContainerView (#1000)
The function was defined inside a #if DEBUG block but called from
non-DEBUG code, breaking Release builds (nightly CI).
2026-03-05 22:18:48 -08:00
Lawrence Chen
5f82a1ae2a Run notify regression through a real terminal 2026-03-05 22:18:14 -08:00
Austin Wang
138ed0e2f0
Merge pull request #990 from manaflow-ai/issue-983-browser-unfocusable-after-cmdr
Fix browser focus after dismissing the command palette by click
2026-03-05 22:17:06 -08:00
Lawrence Chen
8a05c7d1da Decouple command palette search from typing 2026-03-05 22:08:09 -08:00
Lawrence Chen
21bb31dcfb Avoid blocking notify regression socket replies 2026-03-05 21:58:38 -08:00
austinpower1258
2427a2a736 Fix browser portal anchor churn during pane drag 2026-03-05 21:55:26 -08:00
Austin Wang
a7cef78725
Revert "Fix notification unread persistence when workspaces regain focus (#971)" (#992)
This reverts commit 5f43a3fc32.
2026-03-05 21:31:13 -08:00
austinpower1258
44910d03e8 fix: preserve browser target lookup on palette dismiss 2026-03-05 21:29:58 -08:00
Austin Wang
15c7c0cc3c
Fix side-docked dev tools resize (#712)
* wip

* Fix side-docked dev tools resize
2026-03-05 21:28:31 -08:00
Lawrence Chen
335aaaecec Fix send_workspace routing in inactive windows 2026-03-05 21:24:25 -08:00
austinpower1258
82d6086d69 fix: restore browser focus on command palette backdrop click 2026-03-05 21:22:22 -08:00
Lawrence Chen
6f01acfb5f Speed up command palette search 2026-03-05 21:18:39 -08:00
austinpower1258
1291776597 Refresh background workspace git metadata after external checkout 2026-03-05 21:18:04 -08:00
Lawrence Chen
29054dc709
Add sidebar help menu to footer (#958)
* Add sidebar help menu

* Fix help menu test wiring

* Fix help menu accessibility

* Use native popup for help menu

* Use icon button for sidebar help

* Add feedback composer and feedback API

* Allow preview builds without feedback env

* Tighten feedback upload limits

* Adjust sidebar footer padding

* Tighten sidebar footer spacing

* Add link affordances to help menu

* Polish sidebar feedback composer

* Move feedback icon to trailing edge

* Normalize help menu trailing icon sizes

* Enlarge help menu trailing icons

* Reduce help menu link icon size

* Shrink help menu link arrow

* Reduce help menu link arrow again

* Fix feedback message editor focus

* Add send feedback keyboard shortcut

* Polish feedback launch and delivery
2026-03-05 21:00:42 -08:00
austinpower1258
7af383c3d0 Merge branch 'main' of https://github.com/manaflow-ai/cmux into issue-915-terminal-not-loaded 2026-03-05 20:58:49 -08:00
austinpower1258
990b6ba12a ok 2026-03-05 20:51:51 -08:00
Lawrence Chen
2023d8eb57 Fallback panel lookup for notify UI setup 2026-03-05 20:34:51 -08:00
Austin Wang
b848d60b0d
Merge pull request #925 from jleechanorg/fix-split-cwd-inheritance
Fix split CWD inheritance and bash job notification spam
2026-03-05 20:34:25 -08:00
Lawrence Chen
acd8dbff69 Keep send_workspace test-only 2026-03-05 20:24:49 -08:00
Lawrence Chen
e6e5a57dd6 Send notify regression input via workspace socket 2026-03-05 20:18:45 -08:00
Lawrence Chen
6c163b1eb0 Run notify regression from in-app shell 2026-03-05 20:04:52 -08:00
Austin Wang
c5577dd495
Fix flaky CLI socket listener recovery (#952) (#954)
* Harden socket listener health checks and path handling

* Make socket health probe non-blocking

* Address PR feedback for issue 952 recovery guard

* Run issue 952 regression guard without pytest dependency

* Harden socket probe timing and health telemetry

* Handle missing git in issue 952 regression guard

* Address remaining PR 954 review fixes
2026-03-05 19:52:59 -08:00
Lawrence Chen
f9dbbd3562 Reset surface wait timeout in notify UI setup 2026-03-05 19:26:08 -08:00
Lawrence Chen
2b99af19bc Harden multi-window notify regression test 2026-03-05 19:18:01 -08:00
Lawrence Chen
d99fa96c09
Fix browser screenshot to return image URL (#936)
* Return browser screenshot image URL

* Make screenshot path/url best effort

* cli: omit screenshot png_base64 from json output

* browser wait: fail fast on js errors and include screenshot in help

* browser wait: avoid main-actor default world warning

* tests: scope contentWorld regression check to function signature

* browser screenshot: clean up output handling and tests

* browser wait: resolve snapshot refs in selector waits
2026-03-05 19:09:29 -08:00
Austin Wang
5f43a3fc32
Fix notification unread persistence when workspaces regain focus (#971)
* Fix notification unread persistence on focus

* Address review feedback on notification unread fix
2026-03-05 18:56:03 -08:00
Lawrence Chen
6347571b7c
Fix Dvorak Cmd+C colliding with notifications shortcut (#762)
* Fix layout-safe command shortcut matching

* Fix unshifted symbol shortcut coercion

* Fix layout handling for hardcoded Cmd shortcuts

* Support Cmd/Ctrl modifier hold shortcut hints

* Address PR shortcut review feedback

* Handle Caps Lock in command shortcut matching

* Address remaining PR shortcut review comments

* Handle Cmd+Ctrl+F control-character fallback

* Tighten shortcut hint hold-delay test

* Expose shortcut hint visibility in settings

* Restore Cmd+digit fallback on symbol-first layouts

* Stabilize shortcut regression coverage

* Align shortcut hint toggle with Cmd/Ctrl behavior

* Restore Claude workflow file

* Match Claude workflow file to main

* Keep shortcut hint hold behavior command-only

* Restore command shortcut fallback when layout data is unavailable

* Preserve command-aware shortcut translation
2026-03-05 18:32:42 -08:00
Lawrence Chen
5fa3570632 Harden notify focus regression socket checks 2026-03-05 18:10:00 -08:00
Lawrence Chen
ee899042ca Publish socket health into notify focus UI test 2026-03-05 17:35:57 -08:00
Lawrence Chen
e49e572505
Fix browser Cmd+F overlay clipping in portal mode (#916)
* Fix browser Cmd+F overlay clipping in portal mode

* Fix browser Cmd+F panel update regression

* Fix browser find overlay lifecycle and focus

* Extract regression test helpers for browser find guards

* Restore new-tab Cmd+F overlay and harden test helper

* Fix browser Cmd+F focus handoff race

* Fix browser Cmd+F focus loss across page load

* Address review feedback on browser find focus guards

* Add Cmd+F pane-switch regression UI tests

* Run Cmd+F pane-switch regressions from existing UI suite

* Restore browser find focus on pane refocus

* Stabilize Cmd+F pane-switch regressions with focus-state recorder

* Make autofocus race UI test wait on deterministic page signal

* Fix cmuxTests WebViewRepresentable init after browser search state param
2026-03-05 15:36:47 -08:00
Austin Wang
9b215eddab
Fix browser portal pane drag routing and uploads (#961) 2026-03-05 15:27:17 -08:00
Lawrence Chen
1408cbb68c
Flush PostHog hourly active events immediately (#934)
* PostHog: flush hourly active captures immediately

* PostHog: move focus-triggered active tracking off main queue

* Lighten PostHog app focus hot path

* Address review: dedupe PostHog event names
2026-03-05 04:00:04 -08:00
Yuki Yamashina
11197a49c4
Fix startup SIGSEGV: pre-warm locale before SentrySDK.start (#927)
Locale initialization on the main thread (os.locale.ensureLocale /
NSLocale._preferredLanguages) can race with Sentry's background
init thread calling posix.getenv, causing a SIGSEGV and leaving
the SDK disabled.

Related to #836
2026-03-05 03:03:32 -08:00
atani
3a5bd8494c
fix: avoid NSTextView tracking loop in omnibar mouseDown (#928)
* fix: avoid NSTextView tracking loop in omnibar mouseDown (#917)

Replace the synthetic mouseUp timeout workaround with direct cursor
positioning via NSTextView.characterIndexForInsertion(at:). The previous
approach posted a fake mouseUp event via NSApp.postEvent after 3 seconds,
but the NSTextView tracking loop does not always dequeue events from the
application event queue when stuck in an infinite
NSTextLayoutManager.enumerateTextLayoutFragments cycle, so the hang
persisted.

The new approach bypasses super.mouseDown entirely when the field editor
is already active, positioning the cursor (or extending the selection
with Shift+click) without entering the tracking loop. Drag-to-select is
not supported in this code path, but for a single-line omnibar this is
an acceptable trade-off.

* fix: handle double-click, UTF-16 length, and shift-click anchor

Address review feedback:

- Forward double/triple-click events to editor.mouseDown(with:) to
  preserve word and line selection without entering NSTextField's
  tracking loop
- Use (editor.string as NSString).length instead of String.count for
  NSRange clamping (NSRange uses UTF-16 indices)
- Track shift-click anchor independently via shiftClickAnchor property
  to correctly handle bidirectional selection extension

* fix: reset shiftClickAnchor on keyDown to prevent stale anchor

Clear the shift-click selection anchor whenever a key is pressed, so
that keyboard navigation (arrow keys, Shift+arrow, Home/End, etc.)
properly invalidates the mouse-originated anchor. A subsequent
Shift+click will then use the current selection position as anchor
instead of a stale value from a prior mouse interaction.

* fix: reset shiftClickAnchor in performKeyEquivalent and on re-focus

Key equivalents (Cmd+A, Cmd+V, etc.) bypass keyDown and go through
performKeyEquivalent, so the anchor must also be cleared there.
Similarly, re-focusing the field (currentEditor() == nil path) should
reset the anchor since selectAll changes the selection state.
2026-03-05 02:31:23 -08:00
Lawrence Chen
4351c3cf18 Fix notify CLI focus-steal regression and add UI test 2026-03-05 02:20:27 -08:00