Commit graph

139 commits

Author SHA1 Message Date
Lawrence Chen
2eae782739 Merge remote-tracking branch 'origin/main' into pr-ssh-stack-main
# Conflicts:
#	.github/workflows/ci.yml
#	CLI/cmux.swift
#	Sources/GhosttyTerminalView.swift
#	Sources/SocketControlSettings.swift
#	Sources/TabManager.swift
#	Sources/TerminalController.swift
#	Sources/Workspace.swift
#	ghostty
#	scripts/reload.sh
2026-03-13 17:56:38 -07:00
Lawrence Chen
ccdadfa08c
Add CI guard for GhosttyKit checksum pins 2026-03-13 17:28:32 -07:00
Lawrence Chen
85e6a5aae4 Fix ssh stack review regressions 2026-03-13 07:29:22 -07:00
Lawrence Chen
965965c879 Merge origin/main into pr-ssh-stack-main 2026-03-13 06:25:08 -07:00
Lawrence Chen
e6309e7841
Harden the nightly workflow (#1356) 2026-03-13 04:56:19 -07:00
Lawrence Chen
601e5a92e4 Merge origin/main into pr-ssh-stack-main 2026-03-13 04:18:07 -07:00
Lawrence Chen
2ed7f731ed
Build only universal nightly artifacts (#1332) 2026-03-13 03:50:53 -07:00
Lawrence Chen
19b59cae37 Reapply "Merge pull request #239 from manaflow-ai/issue-151-ssh-remote-port-proxying"
This reverts commit f7cbbad434.
2026-03-12 15:54:26 -07:00
Lawrence Chen
f7cbbad434 Revert "Merge pull request #239 from manaflow-ai/issue-151-ssh-remote-port-proxying"
This reverts commit 78e4bd32ba, reversing
changes made to cf75da8f8a.
2026-03-12 14:45:58 -07:00
Lawrence Chen
b12f70b26c Merge origin/main into issue-151-ssh-remote-port-proxying 2026-03-12 05:09:03 -07:00
Lawrence Chen
8a9e28e129 Secure remote daemon distribution and relay auth 2026-03-12 05:04:44 -07:00
Lawrence Chen
76cfe01fa2 Add remote daemon distribution regressions 2026-03-12 05:04:35 -07:00
tiffanysun1
9bd22d5d98 Pick newest CLI binary in CI 2026-03-12 02:34:04 -07:00
tiffanysun1
f50f70dc41 Run version memory guard in CI 2026-03-12 02:19:51 -07:00
austinpower1258
968ccf094f Revert CI workflow changes from #1224
Roll back actions/checkout v6.0.2 to v4, restore oven-sh/setup-bun
action, and remove explicit ref parameter from compat workflow.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-11 21:27:44 -07:00
austinpower1258
27e598ca5a Address CI blockers and review follow-ups 2026-03-11 21:13:25 -07:00
Lawrence Chen
9fdf3d0f84 Fix nightly workflow main push cancellation 2026-03-10 21:29:56 -07:00
Lawrence Chen
b3ed48191e Fix main CI failures 2026-03-09 19:11:37 -07:00
Lawrence Chen
21e1030121 Remove deleted regression guard from CI 2026-03-09 17:18:36 -07:00
Lawrence Chen
4cce891ae3 Keep Apple Silicon nightly arm64-only 2026-03-08 05:13:38 -07:00
Lawrence Chen
76f53aaf90 Build universal GhosttyKit for Release 2026-03-08 04:21:23 -07:00
Lawrence Chen
e23eb285cd Publish separate universal nightly track 2026-03-08 03:09:49 -07:00
Lawrence Chen
1ed4aa159d Build universal nightly app on GitHub runner 2026-03-07 16:27:28 -08:00
Lawrence Chen
58bcc929b2
Verify GhosttyKit artifact integrity in CI/nightly/release workflows (#1032)
* Verify GhosttyKit checksum in build workflows

* Pin GhosttyKit checksums in build workflows

* Tighten GhosttyKit checksum guards
2026-03-07 02:23:23 -08:00
Lawrence Chen
c37ace5deb
Cache Swift packages across CI runs (#998)
* Cache Swift packages across CI runs

Add actions/cache for the SPM cloned source packages directory so
subsequent runs skip fetching Sparkle, sentry-cocoa, swift-markdown-ui,
posthog-ios, and NetworkImage from GitHub each time.

- nightly/release: replace the no-op SwiftPM cache step with
  actions/cache + -clonedSourcePackagesDirPath on xcodebuild
- ci/ci-macos-compat/test-e2e: add actions/cache before the existing
  resolve step, stop deleting the cache dir each run

* Include runner in test-e2e cache key

Consistent with ci-macos-compat.yml which uses matrix.os in the key.
2026-03-05 23:26:05 -08:00
Austin Wang
c5577dd495
Fix flaky CLI socket listener recovery (#952) (#954)
* Harden socket listener health checks and path handling

* Make socket health probe non-blocking

* Address PR feedback for issue 952 recovery guard

* Run issue 952 regression guard without pytest dependency

* Harden socket probe timing and health telemetry

* Handle missing git in issue 952 regression guard

* Address remaining PR 954 review fixes
2026-03-05 19:52:59 -08:00
Lawrence Chen
0fb2b414b0
"Claude PR Assistant workflow" (#965) 2026-03-05 17:19:02 -08:00
Lawrence Chen
3d6645cb18
Add PR template section for demo videos (#933)
* Add PR template section for demo videos

* Remove PR template author exemption note

* Refine PR template with review trigger checklist
2026-03-05 03:05:35 -08:00
Lawrence Chen
017f4416d0
Prompt bug reporters to test NIGHTLY (#930) 2026-03-05 01:48:09 -08:00
Lawrence Chen
4af2e6be30
Remove hourly cron and skipped job from nightly workflow (#817)
Every merge to main already triggers a nightly build, making the hourly
cron redundant. The skipped job was cosmetic (just echoed a message) and
caused confusing red X statuses when cancel-in-progress kicked in.
2026-03-03 15:42:09 -08:00
Lawrence Chen
37dc43a6de
Fix TCC dialog, trim black frames, add macos-26 runner option (#784)
- Grant kTCCServiceScreenCapture in system-level TCC database (sudo)
  and pre-date ScreenCaptureApprovals.plist to suppress Sequoia's
  private window picker dialog
- Move recording start to right before xcodebuild test (skip build time)
- Trim leading black frames from video using ffmpeg blackdetect
- Add runner input: macos-15 (Sequoia) or macos-26 (Tahoe)
2026-03-02 23:14:27 -08:00
Lawrence Chen
d77299c220
Clean up E2E ffmpeg device detection (#782)
* Install ffmpeg via brew for screen recording

macos-15 GitHub runners don't have ffmpeg pre-installed.

* Clean up ffmpeg device detection and add fallback

Suppress noisy device listing errors, add fallback to index 1 if
detected index fails, upgrade warning to error on total failure.
2026-03-02 22:55:03 -08:00
Lawrence Chen
63e7cc7faa
Install ffmpeg via brew for screen recording (#781)
macos-15 GitHub runners don't have ffmpeg pre-installed.
2026-03-02 22:45:22 -08:00
Lawrence Chen
3cb101f1c8
Switch screen recording from screencapture to ffmpeg AVFoundation (#780)
screencapture -v produces a 0-second file on GitHub Actions M-series
runners (IOServiceMatchingfailed for AppleM2ScalerParavirtDriver).
ffmpeg with avfoundation input handles virtual displays correctly.
2026-03-02 22:36:07 -08:00
Lawrence Chen
cd0c3cfa93
Add E2E test workflow with video recording (#778)
* Add E2E test workflow with video recording and issue posting

New workflow_dispatch workflow (test-e2e.yml) that runs XCUITests on
GitHub-hosted macos-15 runners, records the virtual display, uploads the
video as an artifact, and posts results as an issue on cmux-dev-artifacts.

Includes scripts/run-e2e.sh for convenient triggering from the terminal.

* Print issue URL in workflow annotation and run-e2e.sh output

- Capture gh issue create output URL, print as ::notice annotation
- Search issues by run ID instead of grabbing most recent
2026-03-02 22:16:38 -08:00
Lawrence Chen
fe3e2d06d9
Trigger nightly on push to main, switch to GitHub macos-15 runner (#779)
Build immediately on merge instead of waiting for the hourly cron.
Concurrency group cancels in-progress builds when new commits land.
Depot macos runner replaced with GitHub macos-15 (similar perf, simpler).
2026-03-02 22:13:03 -08:00
Lawrence Chen
225588ccfc
Split CI: GitHub runners for tests, Depot for perf regression (#773)
* Split CI: GitHub runners for tests, Depot for perf regression

Unit/UI tests move to macos-15 (no queue wait, fast enough for test
suites). Typing-lag regression stays on Depot in a new tests-depot job
(needs stronger hardware). No duplicated test work between the two.

* Fix Xcode selection: add pipefail guard, use sort|tail for consistency

Address review comments:
- tests job: add || true to ls pipeline so fallback works under pipefail
- tests-depot job: use sort | tail -n 1 instead of head -n 1

* Move XCUITests from GitHub runner to Depot

tests (macos-15) now runs unit tests only. tests-depot (Depot) runs
UI tests and the typing-lag regression, reusing the same build.
2026-03-02 21:31:39 -08:00
Lawrence Chen
682a57d7db
Add workspace-churn typing lag regression and fix (#767)
* Add workspace-churn typing lag regression and fix

* Fix CI build for debug stress split calls

* Stabilize lag regression gate for low baseline latency
2026-03-02 19:06:50 -08:00
Lawrence Chen
b3f6f8cfd7
Add macOS compatibility CI: unit tests + smoke test on macos-14/15 (#769)
* Add macOS compatibility CI: unit tests + smoke test on macos-14/15

New workflow runs on GitHub-hosted macos-14 and macos-15 runners
(matrix strategy). Each run: unit tests via cmux-unit scheme, then
a smoke test that builds the app, launches it, sends a command via
the socket, and verifies it stays alive for 15 seconds.

* Select latest Xcode on runner (fix macos-14 Swift tools version)

macos-14 runners default to Xcode 15.4, but sentry-cocoa needs
Swift tools version 6.0 (Xcode 16+). Pick the latest Xcode_*.app
instead of the default symlink.

* Launch app binary directly in smoke test for better CI compatibility

Using `open` can fail silently on CI runners. Launch the binary
directly with env vars set, capture stdout/stderr, and add process
health checks with diagnostic output (debug log tail, crash reports)
on failure.
2026-03-02 18:50:27 -08:00
Lawrence Chen
58bb9bc655
Migrate all workflows from self-hosted Mac Mini to Depot runners (#730)
* Migrate all workflows from self-hosted Mac Mini to Depot runners

Move CI, nightly, and release workflows to depot-macos-latest. Replace
zig GhosttyKit builds with pre-built xcframework downloads. Add virtual
display for CI UI tests. Remove concurrency groups (ephemeral VMs don't
need them).

* Add per-test timeout to CI UI tests to prevent hangs on Depot

SidebarResizeUITests hangs on headless Depot runners due to mouse drag
simulation issues. Adding -maximum-test-execution-time-allowance 120
(matching test-depot.yml) ensures individual tests timeout after 2 min
instead of blocking the entire run.

* Skip SidebarResizeUITests in CI on Depot runners

Mouse drag simulation hangs on headless Depot runners even with a
virtual display. The per-test timeout doesn't prevent the hang either.
Skip this test class in CI; it still runs fine on local machines.

* Handle XCTExpectFailure in CI UI tests (exit 65 with 0 unexpected)

xcodebuild exits 65 even when all failures use XCTExpectFailure. Add
the same expected-failure handling from the unit test step so browser
focus tests (which are expected to fail on headless runners) don't
break CI.
2026-03-01 19:06:45 -08:00
Lawrence Chen
1fcbdc9417
Split self-hosted concurrency groups per workflow (#729)
* Add virtual display for headless Depot runners

Depot macOS runners have no physical display, causing XCUITests to fail
with "Failed to activate application (current state: Running Background)".
This adds a small ObjC tool that creates a virtual display using the
private CGVirtualDisplay API before tests run.

* Split self-hosted concurrency groups per workflow

CI, nightly, and release all shared `self-hosted-build`, so the hourly
nightly cancelled in-progress CI runs. Now each workflow has its own
group (self-hosted-ci, self-hosted-nightly, self-hosted-release).

CI also gets cancel-in-progress: true so rapid pushes cancel stale runs.
2026-03-01 16:34:38 -08:00
Lawrence Chen
2b66a2f5c1
Add virtual display for headless Depot runners (#721)
Depot macOS runners have no physical display, causing XCUITests to fail
with "Failed to activate application (current state: Running Background)".
This adds a small ObjC tool that creates a virtual display using the
private CGVirtualDisplay API before tests run.
2026-03-01 04:25:36 -08:00
Lawrence Chen
1b160dc5ca
Add display diagnostics, test filter, and per-test timeout to Depot workflow (#720)
- Display diagnostics step to debug headless display issues
- test_filter input to run specific XCUITest classes
- test_timeout input (default 120s) to prevent test hangs
2026-03-01 04:04:32 -08:00
Lawrence Chen
e295f384fc
Run all XCUITests in CI and add skip_unit_tests to Depot workflow (#718)
* Run all XCUITests in CI instead of just UpdatePillUITests

Removes the -only-testing:cmuxUITests/UpdatePillUITests filter so
new test classes are picked up automatically. No more workflow edits
needed when adding tests.

* Add skip_unit_tests input to test-depot workflow
2026-03-01 02:58:27 -08:00
Austin Wang
dba1e232d3
Fix SwiftPM binary artifact cache collision in CI (#716)
After rm -rf of the SPM cache dir, recreate it as an empty directory
so binary target downloads (e.g. Sentry.xcframework.zip) don't hit
"already exists in file system" errors from stale artifacts on the
self-hosted runner.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-28 23:18:21 -08:00
Lawrence Chen
9d00ae9ab0
Move Build GhosttyKit to Depot to avoid self-hosted concurrency cancellations (#713)
build-ghosttykit shared the self-hosted-build concurrency group with
CI tests, causing one to get cancelled when both trigger on the same
push. Most runs are no-ops (xcframework already exists), so Depot is
a good fit. Eliminates the red X on pushes to main.
2026-02-28 22:46:15 -08:00
Lawrence Chen
b6efd73d57
Switch CI and Build GhosttyKit to Depot macOS runners (#710)
* Switch CI and Build GhosttyKit to Depot macOS runners

Moves the tests job (unit + UI) and build-ghosttykit job from
self-hosted to depot-macos-latest so CI doesn't block the local
Mac Mini. CI tests now download the pre-built xcframework from
the ghostty releases instead of building with zig. Nightly and
release workflows stay on self-hosted for signing/notarization.

* Add on-demand Depot test workflow, revert CI changes

Adds test-depot.yml (workflow_dispatch) for running tests on Depot
macOS runners during local dev without tying up the Mac Mini.
Reverts ci.yml and build-ghosttykit.yml back to self-hosted.
2026-02-28 22:32:51 -08:00
Lawrence Chen
f451766d12
Add cmux <path> to open directories and Homebrew binary stanza (#705)
* Add `cmux <path>` to open directories and Homebrew binary stanza

CLI: `cmux .` or `cmux /path/to/dir` opens a new workspace at the
given directory. If the app isn't running, it launches first and waits
for the socket. Also adds `--cwd` flag to `new-workspace`.

Server: `workspace.create` now accepts an optional `cwd` parameter,
passed through to `TabManager.addWorkspace(workingDirectory:)`.

Homebrew: adds `binary` stanza to the cask so `cmux` CLI is globally
available after `brew install --cask cmux`. Updated both the cask file,
the CI workflow template, and the manual release script so automated
version bumps preserve the stanza.

* Address review: validate cwd type, fix socket detection, propagate errors

- looksLikePath now also matches paths containing `/` (e.g. `foo/bar`)
- openPath uses socket connection attempt instead of fileExists to detect
  whether the app is running (Unix sockets may not appear on filesystem)
- launchApp/activateApp now throw instead of swallowing errors with try?
- Server validates that cwd param is a string, returns invalid_params error
  if wrong type is passed
2026-02-28 20:25:41 -08:00
Lawrence Chen
7916b2d418
Fix Xcode Cloud UI tests by running TestAction in Debug (#672)
* Set cmux TestAction to Debug for UI tests

* Broaden XCTest detection for debug launch gate

* Fix AutomationSocketUITests launch hang in CI

* Stabilize CI Swift package resolution for test jobs

* Stabilize Xcode Cloud UI test focus and socket handling

* Add Xcode Cloud pre-xcodebuild submodule bootstrap

* Harden Xcode Cloud bonsplit bootstrap fallback
2026-02-28 01:48:49 -08:00
Lawrence Chen
be89812bea
Harden CI unit tests against SwiftPM artifact flakes (#682) 2026-02-28 00:38:46 -08:00