marketing-shibata50/multica
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #413 from cocovs/codex/fix-daemon-pid-minus1

Browse source 
fix(cli): preserve daemon pid before releasing child process
This commit is contained in:
Bohan Jiang 2026-04-07 14:18:12 +08:00 • committed by GitHub
commit 4cf18e122d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
server/cmd/multica/cmd_daemon.go
View file

@ -163,13 +163,14 @@ func runDaemonBackground(cmd *cobra.Command) error {
return fmt.Errorf("start daemon: %w", err)
}
logFile.Close()
pid := child.Process.Pid
// Detach: we don't Wait() on the child — it runs independently.
child.Process.Release()
// Write PID file.
pidPath := daemonPIDPathForProfile(profile)
if err := os.WriteFile(pidPath, []byte(strconv.Itoa(child.Process.Pid)), 0o644); err != nil {
if err := os.WriteFile(pidPath, []byte(strconv.Itoa(pid)), 0o644); err != nil {
fmt.Fprintf(os.Stderr, "Warning: could not write PID file: %v\n", err)
}
@ -184,9 +185,9 @@ func runDaemonBackground(cmd *cobra.Command) error {
}
if profile != "" {
fmt.Fprintf(os.Stderr, "Daemon [%s] started (pid %d, version %s)\n", profile, child.Process.Pid, version)
fmt.Fprintf(os.Stderr, "Daemon [%s] started (pid %d, version %s)\n", profile, pid, version)
} else {
fmt.Fprintf(os.Stderr, "Daemon started (pid %d, version %s)\n", child.Process.Pid, version)
fmt.Fprintf(os.Stderr, "Daemon started (pid %d, version %s)\n", pid, version)
}
fmt.Fprintf(os.Stderr, "Logs: %s\n", logPath)
return nil