fix(comments): address code review feedback on pagination

1. Update CLAUDE.md template to document --limit, --offset, --since
   params and guide agents to use pagination when comments are large
2. Add GetJSONWithHeaders to API client; CLI now prints "Showing X of Y
   comments" to stderr when paginating
3. Cap --since without --limit at 500 server-side to prevent unbounded
   result sets
This commit is contained in:
Jiayuan 2026-04-04 01:01:48 +08:00
parent 0bbc6bc1c5
commit c39470a53f
4 changed files with 49 additions and 4 deletions

View file

@ -109,11 +109,16 @@ func (h *Handler) ListComments(w http.ResponseWriter, r *http.Request) {
Offset: offset,
})
case sinceTime.Valid:
comments, err = h.Queries.ListCommentsSince(r.Context(), db.ListCommentsSinceParams{
// Apply a server-side cap to prevent unbounded result sets when
// --since is used without --limit.
comments, err = h.Queries.ListCommentsSincePaginated(r.Context(), db.ListCommentsSincePaginatedParams{
IssueID: issue.ID,
WorkspaceID: issue.WorkspaceID,
CreatedAt: sinceTime,
Limit: 500,
Offset: 0,
})
hasPagination = true
case hasPagination:
if limit == 0 {
limit = 50