actor_id identifies the user, not the browser tab. Filtering WS events by actor_id broke multi-tab sync — other tabs of the same user would silently miss updates. Instead, make all WS cache handlers idempotent (dedup checks on add, no-op on duplicate merge/filter) so mutations and WS events coexist safely without filtering. - WSClient: pass actor_id to event handlers for future per-handler use - use-realtime-sync: remove isSelf() gating from onAny and specific handlers - useCreateIssue: add .some() dedup guard + onSettled invalidation - use-issue-reactions: remove payload-level self-filter (dedup already present) - use-issue-timeline: remove payload-level self-filter on comment:created, reaction:added, reaction:removed (dedup already present) - Clean up useCallback deps that no longer reference userId Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
33 lines
905 B
TypeScript
33 lines
905 B
TypeScript
"use client";
|
|
|
|
import { useEffect } from "react";
|
|
import type { WSEventType } from "@/shared/types";
|
|
import { useWS } from "./provider";
|
|
|
|
type EventHandler = (payload: unknown, actorId?: string) => void;
|
|
|
|
/**
|
|
* Hook that subscribes to a WebSocket event and calls the handler.
|
|
* Automatically unsubscribes on cleanup.
|
|
*/
|
|
export function useWSEvent(event: WSEventType, handler: EventHandler) {
|
|
const { subscribe } = useWS();
|
|
|
|
useEffect(() => {
|
|
const unsub = subscribe(event, handler);
|
|
return unsub;
|
|
}, [event, handler, subscribe]);
|
|
}
|
|
|
|
/**
|
|
* Hook that registers a callback to run on WebSocket reconnection.
|
|
* Useful for refetching component-local data after a network interruption.
|
|
*/
|
|
export function useWSReconnect(callback: () => void) {
|
|
const { onReconnect } = useWS();
|
|
|
|
useEffect(() => {
|
|
const unsub = onReconnect(callback);
|
|
return unsub;
|
|
}, [callback, onReconnect]);
|
|
}
|