d58f6cdb33
actor_id identifies the user, not the browser tab. Filtering WS events by actor_id broke multi-tab sync — other tabs of the same user would silently miss updates. Instead, make all WS cache handlers idempotent (dedup checks on add, no-op on duplicate merge/filter) so mutations and WS events coexist safely without filtering. - WSClient: pass actor_id to event handlers for future per-handler use - use-realtime-sync: remove isSelf() gating from onAny and specific handlers - useCreateIssue: add .some() dedup guard + onSettled invalidation - use-issue-reactions: remove payload-level self-filter (dedup already present) - use-issue-timeline: remove payload-level self-filter on comment:created, reaction:added, reaction:removed (dedup already present) - Clean up useCallback deps that no longer reference userId Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
91 lines
2.4 KiB
TypeScript
91 lines
2.4 KiB
TypeScript
"use client";
|
|
|
|
import {
|
|
createContext,
|
|
useContext,
|
|
useEffect,
|
|
useState,
|
|
useRef,
|
|
useCallback,
|
|
type ReactNode,
|
|
} from "react";
|
|
import { WSClient } from "@/shared/api";
|
|
import type { WSEventType } from "@/shared/types";
|
|
import { useAuthStore } from "@/features/auth";
|
|
import { useWorkspaceStore } from "@/features/workspace";
|
|
import { createLogger } from "@/shared/logger";
|
|
import { useRealtimeSync } from "./use-realtime-sync";
|
|
|
|
const WS_URL =
|
|
process.env.NEXT_PUBLIC_WS_URL ||
|
|
(typeof window !== "undefined"
|
|
? `${window.location.protocol === "https:" ? "wss:" : "ws:"}//${window.location.host}/ws`
|
|
: "ws://localhost:8080/ws");
|
|
|
|
type EventHandler = (payload: unknown, actorId?: string) => void;
|
|
|
|
interface WSContextValue {
|
|
subscribe: (event: WSEventType, handler: EventHandler) => () => void;
|
|
onReconnect: (callback: () => void) => () => void;
|
|
}
|
|
|
|
const WSContext = createContext<WSContextValue | null>(null);
|
|
|
|
export function WSProvider({ children }: { children: ReactNode }) {
|
|
const user = useAuthStore((s) => s.user);
|
|
const workspace = useWorkspaceStore((s) => s.workspace);
|
|
const [wsClient, setWsClient] = useState<WSClient | null>(null);
|
|
const wsRef = useRef<WSClient | null>(null);
|
|
|
|
useEffect(() => {
|
|
if (!user || !workspace) return;
|
|
|
|
const token = localStorage.getItem("multica_token");
|
|
if (!token) return;
|
|
|
|
const ws = new WSClient(WS_URL, { logger: createLogger("ws") });
|
|
ws.setAuth(token, workspace.id);
|
|
wsRef.current = ws;
|
|
setWsClient(ws);
|
|
ws.connect();
|
|
|
|
return () => {
|
|
ws.disconnect();
|
|
wsRef.current = null;
|
|
setWsClient(null);
|
|
};
|
|
}, [user, workspace]);
|
|
|
|
// Centralized WS → store sync (uses state so it re-subscribes when WS changes)
|
|
useRealtimeSync(wsClient);
|
|
|
|
const subscribe = useCallback(
|
|
(event: WSEventType, handler: EventHandler) => {
|
|
const ws = wsRef.current;
|
|
if (!ws) return () => {};
|
|
return ws.on(event, handler);
|
|
},
|
|
[],
|
|
);
|
|
|
|
const onReconnectCb = useCallback(
|
|
(callback: () => void) => {
|
|
const ws = wsRef.current;
|
|
if (!ws) return () => {};
|
|
return ws.onReconnect(callback);
|
|
},
|
|
[],
|
|
);
|
|
|
|
return (
|
|
<WSContext.Provider value={{ subscribe, onReconnect: onReconnectCb }}>
|
|
{children}
|
|
</WSContext.Provider>
|
|
);
|
|
}
|
|
|
|
export function useWS() {
|
|
const ctx = useContext(WSContext);
|
|
if (!ctx) throw new Error("useWS must be used within WSProvider");
|
|
return ctx;
|
|
}
|