* fix(web): add load-more pagination for Done column on issue board The Done column was capped at 50 issues with no way to load more. Track doneTotal in the TQ cache and add a useLoadMoreDoneIssues hook that fetches the next page and merges it into the unified issue cache. The Done column now shows a "Load more" button when there are additional items. - shared/types/api.ts: add doneTotal to ListIssuesResponse - core/issues/queries.ts: store doneTotal from the done-status response - core/issues/mutations.ts: add useLoadMoreDoneIssues hook, update create/delete mutations to maintain doneTotal - core/issues/ws-updaters.ts: maintain doneTotal on WS events - features/issues/components/board-column.tsx: accept optional footer - features/issues/components/board-view.tsx: render Load more button in Done column Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(web): address review issues in done-column load-more 1. Fix total over-counting: loadMore no longer inflates total since the initial query already includes all done issues in total count. 2. Fix onIssueUpdated: maintain doneTotal when issue status changes to/from done via WS events. 3. Make doneTotal optional in ListIssuesResponse since it's a frontend-only field not returned by the backend API. All reads now use ?? 0 fallback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
115 lines
3.9 KiB
TypeScript
115 lines
3.9 KiB
TypeScript
"use client";
|
|
|
|
import { useMemo, type ReactNode } from "react";
|
|
import { EyeOff, MoreHorizontal, Plus } from "lucide-react";
|
|
import { Tooltip, TooltipTrigger, TooltipContent } from "@/components/ui/tooltip";
|
|
import { useDroppable } from "@dnd-kit/core";
|
|
import { SortableContext, verticalListSortingStrategy } from "@dnd-kit/sortable";
|
|
import type { Issue, IssueStatus } from "@/shared/types";
|
|
import { Button } from "@/components/ui/button";
|
|
import {
|
|
DropdownMenu,
|
|
DropdownMenuTrigger,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
} from "@/components/ui/dropdown-menu";
|
|
import { STATUS_CONFIG } from "@/features/issues/config";
|
|
import { useModalStore } from "@/features/modals";
|
|
import { useViewStoreApi } from "@/features/issues/stores/view-store-context";
|
|
import { StatusIcon } from "./status-icon";
|
|
import { DraggableBoardCard } from "./board-card";
|
|
|
|
export function BoardColumn({
|
|
status,
|
|
issueIds,
|
|
issueMap,
|
|
footer,
|
|
}: {
|
|
status: IssueStatus;
|
|
issueIds: string[];
|
|
issueMap: Map<string, Issue>;
|
|
footer?: ReactNode;
|
|
}) {
|
|
const cfg = STATUS_CONFIG[status];
|
|
const { setNodeRef, isOver } = useDroppable({ id: status });
|
|
const viewStoreApi = useViewStoreApi();
|
|
|
|
// Resolve IDs to Issue objects, preserving parent-provided order
|
|
const resolvedIssues = useMemo(
|
|
() =>
|
|
issueIds.flatMap((id) => {
|
|
const issue = issueMap.get(id);
|
|
return issue ? [issue] : [];
|
|
}),
|
|
[issueIds, issueMap],
|
|
);
|
|
|
|
return (
|
|
<div className={`flex w-[280px] shrink-0 flex-col rounded-xl ${cfg.columnBg} p-2`}>
|
|
<div className="mb-2 flex items-center justify-between px-1.5">
|
|
{/* Left: status badge + count */}
|
|
<div className="flex items-center gap-2">
|
|
<span className={`inline-flex items-center gap-1.5 rounded px-2 py-0.5 text-xs font-semibold ${cfg.badgeBg} ${cfg.badgeText}`}>
|
|
<StatusIcon status={status} className="h-3 w-3" inheritColor />
|
|
{cfg.label}
|
|
</span>
|
|
<span className="text-xs text-muted-foreground">
|
|
{issueIds.length}
|
|
</span>
|
|
</div>
|
|
|
|
{/* Right: add + menu */}
|
|
<div className="flex items-center gap-1">
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger
|
|
render={
|
|
<Button variant="ghost" size="icon-sm" className="rounded-full text-muted-foreground">
|
|
<MoreHorizontal className="size-3.5" />
|
|
</Button>
|
|
}
|
|
/>
|
|
<DropdownMenuContent align="end">
|
|
<DropdownMenuItem onClick={() => viewStoreApi.getState().hideStatus(status)}>
|
|
<EyeOff className="size-3.5" />
|
|
Hide column
|
|
</DropdownMenuItem>
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
<Tooltip>
|
|
<TooltipTrigger
|
|
render={
|
|
<Button
|
|
variant="ghost"
|
|
size="icon-sm"
|
|
className="rounded-full text-muted-foreground"
|
|
onClick={() => useModalStore.getState().open("create-issue", { status })}
|
|
>
|
|
<Plus className="size-3.5" />
|
|
</Button>
|
|
}
|
|
/>
|
|
<TooltipContent>Add issue</TooltipContent>
|
|
</Tooltip>
|
|
</div>
|
|
</div>
|
|
<div
|
|
ref={setNodeRef}
|
|
className={`min-h-[200px] flex-1 space-y-2 overflow-y-auto rounded-lg p-1 transition-colors ${
|
|
isOver ? "bg-accent/60" : ""
|
|
}`}
|
|
>
|
|
<SortableContext items={issueIds} strategy={verticalListSortingStrategy}>
|
|
{resolvedIssues.map((issue) => (
|
|
<DraggableBoardCard key={issue.id} issue={issue} />
|
|
))}
|
|
</SortableContext>
|
|
{issueIds.length === 0 && (
|
|
<p className="py-8 text-center text-xs text-muted-foreground">
|
|
No issues
|
|
</p>
|
|
)}
|
|
{footer}
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|