marketing-shibata50/tududi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix sidebar toggle causing unnecessary task list reload (#888) (#937)

Browse source 
Remove isSidebarOpen from the useEffect dependency array and from the
API request parameters in Tasks.tsx. The sidebar visibility state has no
bearing on which tasks should be fetched, so toggling it should not
trigger a data re-fetch.
This commit is contained in:
Chris 2026-03-10 18:37:07 +02:00 • committed by GitHub
parent 1a1b70b5e7
commit 23131d686a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
frontend/components/Tasks.tsx
View file

@ -1,7 +1,6 @@
import React, { useEffect, useState, useRef, useMemo } from 'react';
import { useLocation, useNavigate } from 'react-router-dom';
import { useTranslation } from 'react-i18next';
import { useSidebar } from '../contexts/SidebarContext';
import TaskList from './Task/TaskList';
import GroupedTaskList from './Task/GroupedTaskList';
import NewTask from './Task/NewTask';
@ -40,7 +39,7 @@ const getSearchPlaceholder = (language: string): string => {
const Tasks: React.FC = () => {
const { t, i18n } = useTranslation();
const { showSuccessToast } = useToast();
const { isSidebarOpen } = useSidebar();
const [tasks, setTasks] = useState<Task[]>([]);
const projects = useStore((state: any) => state.projectsStore.projects);
const [groupedTasks, setGroupedTasks] = useState<GroupedTasks | null>(null);
@ -197,7 +196,6 @@ const Tasks: React.FC = () => {
allTasksUrl.set('type', 'upcoming');
allTasksUrl.set('groupBy', 'day');
allTasksUrl.set('maxDays', '7');
allTasksUrl.set('sidebarOpen', isSidebarOpen.toString());
allTasksUrl.set('isMobile', isMobile.toString());
}
@ -312,7 +310,7 @@ const Tasks: React.FC = () => {
}
: undefined
);
}, [location, isSidebarOpen, isMobile, groupBy, isUpcomingView]);
}, [location, isMobile, groupBy, isUpcomingView]);
useEffect(() => {
const handleResize = () => {