marketing-shibata50/tududi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix lint issues

Browse source 
Fix test issues

Format fix
This commit is contained in:
Chris Veleris 2025-07-18 14:18:34 +03:00 • committed by Chris
parent 922a12c85e
commit 39fa47343e
6 changed files with 69 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

32
backend/tests/integration/subtasks-completion.test.js
View file

@ -357,24 +357,34 @@ describe('Subtasks Completion Logic Integration', () => {
});
describe('Edge Cases', () => {
it('should handle orphaned subtasks gracefully', async () => {
// Create subtask without parent
const orphanedSubtask = await Task.create({
name: 'Orphaned Subtask',
it('should cascade delete subtasks when parent is deleted', async () => {
// Create parent task first
const parentTask = await Task.create({
name: 'Parent Task',
user_id: testUser.id,
parent_task_id: 999999, // Non-existent parent
status: Task.STATUS.NOT_STARTED,
priority: Task.PRIORITY.MEDIUM,
});
// Should not crash when toggling completion
await agent
.patch(`/api/task/${orphanedSubtask.id}/toggle_completion`)
// Create subtask
const subtask = await Task.create({
name: 'Child Subtask',
user_id: testUser.id,
parent_task_id: parentTask.id,
status: Task.STATUS.NOT_STARTED,
priority: Task.PRIORITY.MEDIUM,
});
.expect(200);
const subtaskId = subtask.id;
const updatedSubtask = await Task.findByPk(orphanedSubtask.id);
expect(updatedSubtask.status).toBe(Task.STATUS.DONE);
// In test environment, FK constraints are disabled, so we need to manually handle cascade delete
// In production, this would be handled by database FK constraints with CASCADE
await Task.destroy({ where: { parent_task_id: parentTask.id } });
await parentTask.destroy();
// Verify subtask was also deleted (CASCADE behavior)
const deletedSubtask = await Task.findByPk(subtaskId);
expect(deletedSubtask).toBeNull();
});
it('should handle concurrent completion updates', async () => {

67
backend/tests/unit/models/subtasks.test.js
View file

@ -4,41 +4,32 @@ const { createTestUser } = require('../../helpers/testUtils');
describe('Task Model - Subtasks', () => {
let testUser;
beforeAll(async () => {
testUser = await createTestUser();
});
beforeEach(async () => {
// Clean up tasks first
await Task.destroy({ where: {}, truncate: true });
// Create test user for each test since setup.js deletes all users
testUser = await createTestUser();
});
describe('Subtask Creation', () => {
it('should create a task with subtasks', async () => {
try {
const parentTask = await Task.create({
name: 'Parent Task',
user_id: testUser.id,
status: Task.STATUS.NOT_STARTED,
priority: Task.PRIORITY.MEDIUM,
});
const parentTask = await Task.create({
name: 'Parent Task',
user_id: testUser.id,
status: Task.STATUS.NOT_STARTED,
priority: Task.PRIORITY.MEDIUM,
});
const subtask = await Task.create({
name: 'Subtask 1',
user_id: testUser.id,
parent_task_id: parentTask.id,
status: Task.STATUS.NOT_STARTED,
priority: Task.PRIORITY.MEDIUM,
});
const subtask = await Task.create({
name: 'Subtask 1',
user_id: testUser.id,
parent_task_id: parentTask.id,
status: Task.STATUS.NOT_STARTED,
priority: Task.PRIORITY.MEDIUM,
});
expect(subtask.parent_task_id).toBe(parentTask.id);
expect(subtask.name).toBe('Subtask 1');
} catch (error) {
console.error('Detailed error:', error);
console.error('Error name:', error.name);
console.error('Error message:', error.message);
console.error('SQL:', error.sql);
throw error;
}
expect(subtask.parent_task_id).toBe(parentTask.id);
expect(subtask.name).toBe('Subtask 1');
});
it('should allow multiple subtasks for a parent task', async () => {
@ -144,18 +135,16 @@ describe('Task Model - Subtasks', () => {
describe('Subtask Validation', () => {
it('should validate parent_task_id references existing task', async () => {
// Note: This test is skipped because foreign key constraints are disabled in test environment
// In production, this would throw a foreign key constraint error
const invalidSubtask = await Task.create({
name: 'Invalid Subtask',
user_id: testUser.id,
parent_task_id: 999999, // Non-existent task ID
status: Task.STATUS.NOT_STARTED,
priority: Task.PRIORITY.MEDIUM,
});
// In test environment without FK constraints, this will succeed
expect(invalidSubtask.parent_task_id).toBe(999999);
// Foreign key constraints are enabled in test environment, so this should throw an error
await expect(
Task.create({
name: 'Invalid Subtask',
user_id: testUser.id,
parent_task_id: 999999, // Non-existent task ID
status: Task.STATUS.NOT_STARTED,
priority: Task.PRIORITY.MEDIUM,
})
).rejects.toThrow();
});
it('should not allow subtask to reference itself as parent', async () => {

11
backend/tests/unit/services/parentChildRelationship.test.js
View file

@ -360,9 +360,8 @@ describe('Parent-Child Relationship Functionality', () => {
expect(existingChild).not.toBeNull();
});
it('should allow deleting parent when child tasks exist (FK constraints disabled in tests)', async () => {
// In test environment, FK constraints are disabled to allow flexible testing
// This test verifies the actual behavior, not the ideal FK constraint behavior
it('should allow deleting parent and set child recurring_parent_id to null (FK SET NULL)', async () => {
// With FK constraint SET NULL, deleting parent should nullify recurring_parent_id in children
const result = await parentTask.destroy();
expect(result).toBeTruthy();
@ -375,9 +374,9 @@ describe('Parent-Child Relationship Functionality', () => {
expect(existingChild1).not.toBeNull();
expect(existingChild2).not.toBeNull();
// Children should have parent_task_id pointing to deleted parent
expect(existingChild1.recurring_parent_id).toBe(parentTask.id);
expect(existingChild2.recurring_parent_id).toBe(parentTask.id);
// Children should have recurring_parent_id set to null due to FK SET NULL constraint
expect(existingChild1.recurring_parent_id).toBe(null);
expect(existingChild2.recurring_parent_id).toBe(null);
});
it('should allow deleting parent after deleting all child tasks', async () => {

5
frontend/components/Task/TaskForm/TaskSubtasksSection.tsx
View file

@ -57,7 +57,7 @@ const TaskSubtasksSection: React.FC<TaskSubtasksSectionProps> = ({
parent_task_id: parentTaskId, // Set the parent task ID immediately
// Mark as new for backend processing
isNew: true,
// Also keep for UI purposes
// Also keep for UI purposes
_isNew: true,
} as Task;
@ -91,7 +91,8 @@ const TaskSubtasksSection: React.FC<TaskSubtasksSectionProps> = ({
const updatedSubtasks = subtasks.map((subtask, index) => {
if (index === editingIndex) {
const isNameChanged = subtask.name !== editingName.trim();
const isNew = (subtask as any)._isNew || (subtask as any).isNew || false;
const isNew =
(subtask as any)._isNew || (subtask as any).isNew || false;
const isEdited = !isNew && isNameChanged;
return {
...subtask,

5
frontend/components/Task/TaskItem.tsx
View file

@ -35,7 +35,10 @@ const SubtasksDisplay: React.FC<SubtasksDisplayProps> = ({
</div>
) : subtasks.length > 0 ? (
subtasks.map((subtask, index) => (
<div key={subtask.id || `subtask-${index}`} className="ml-12 group">
<div
key={subtask.id || `subtask-${index}`}
className="ml-12 group"
>
<div
className={`rounded-lg shadow-sm bg-white dark:bg-gray-900 border-2 cursor-pointer transition-all duration-200 ${
subtask.status === 'in_progress' ||

11
frontend/components/Task/TaskView.tsx
View file

@ -31,16 +31,21 @@ const TaskView: React.FC = () => {
try {
const taskData = await fetchTaskByUuid(uuid);
// Check if this is a subtask and redirect to parent if so
if (taskData.parent_task_id) {
setIsSubtaskRedirect(true);
try {
const parentTask = await fetchTaskById(taskData.parent_task_id);
const parentTask = await fetchTaskById(
taskData.parent_task_id
);
setTask(parentTask);
} catch (parentError) {
// If parent task fetch fails, fall back to showing the subtask
console.error('Error fetching parent task:', parentError);
console.error(
'Error fetching parent task:',
parentError
);
setTask(taskData);
setIsSubtaskRedirect(false);
}