From 4051824e7aeb129b23c6079f19b0f3572ed89bd8 Mon Sep 17 00:00:00 2001
From: Antonis Anastasiadis <antanst@antanst.com>
Date: Tue, 22 Jul 2025 15:23:03 +0300
Subject: [PATCH] Configurable upload path. (#191)

* Add necessary migrations for project model.

* Add a few tests for project model new columns.

* make upload location into a configurable

* fix uploadDir path

* use config in app.js

* Change upload env var naming

* Add upload env var to Docker files

---------

Co-authored-by: antanst <>
Co-authored-by: vhsdream <punk.sand7393@fastmail.com>
---
 Dockerfile                   | 6 ++++--
 backend/app.js               | 2 +-
 backend/config/config.js     | 3 +++
 backend/routes/projects.js   | 4 +++-
 docker-compose.yml           | 2 ++
 scripts/docker-entrypoint.sh | 4 ++--
 6 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index bcab015..f41bd16 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -70,7 +70,7 @@ COPY --from=builder --chown=app:app /app/node_modules ./node_modules
 COPY --from=builder --chown=app:app /app/package.json /app/
 
 # Create necessary directories
-RUN mkdir -p /app/backend/db /app/backend/certs
+RUN mkdir -p /app/backend/db /app/backend/certs /app/backend/uploads
 
 # Cleanup
 RUN apk del --no-cache .runtime-deps sqlite openssl curl && \
@@ -79,6 +79,7 @@ RUN apk del --no-cache .runtime-deps sqlite openssl curl && \
     rm -rf /root/.npm /tmp/* /var/tmp/* /var/cache/apk/*
 
 VOLUME ["/app/backend/db"]
+VOLUME ["/app/backend/uploads"]
 
 EXPOSE 3002
 
@@ -91,7 +92,8 @@ ENV NODE_ENV=production \
     TUDUDI_USER_EMAIL="" \
     TUDUDI_USER_PASSWORD="" \
     DISABLE_TELEGRAM=false \
-    DISABLE_SCHEDULER=false
+    DISABLE_SCHEDULER=false \
+    TUDUDI_UPLOAD_PATH="/app/backend/uploads"
 
 HEALTHCHECK --interval=60s --timeout=3s --start-period=10s --retries=2 \
     CMD curl -sf http://localhost:3002/api/health || exit 1
diff --git a/backend/app.js b/backend/app.js
index f5dab3c..504527e 100644
--- a/backend/app.js
+++ b/backend/app.js
@@ -86,7 +86,7 @@ if (config.production) {
 }
 
 // Serve uploaded files
-app.use('/api/uploads', express.static(path.join(__dirname, 'uploads')));
+app.use('/api/uploads', express.static(config.uploadPath));
 
 // Authentication middleware
 const { requireAuth } = require('./middleware/auth');
diff --git a/backend/config/config.js b/backend/config/config.js
index fb3bd9e..86af874 100644
--- a/backend/config/config.js
+++ b/backend/config/config.js
@@ -67,6 +67,9 @@ const config = {
 
     sslEnabled:
         production && process.env.TUDUDI_INTERNAL_SSL_ENABLED === 'true',
+
+    uploadPath:
+        process.env.TUDUDI_UPLOAD_PATH || path.join(projectRootPath, 'uploads'),
 };
 
 console.log(`Using database file '${config.dbFile}'`);
diff --git a/backend/routes/projects.js b/backend/routes/projects.js
index 9163c6c..f46f9bd 100644
--- a/backend/routes/projects.js
+++ b/backend/routes/projects.js
@@ -1,6 +1,8 @@
 const express = require('express');
 const multer = require('multer');
 const path = require('path');
+const { getConfig } = require('../config/config');
+const config = getConfig();
 const fs = require('fs');
 const { Project, Task, Tag, Area, Note, sequelize } = require('../models');
 const { Op } = require('sequelize');
@@ -21,7 +23,7 @@ const formatDate = (date) => {
 // Configure multer for file uploads
 const storage = multer.diskStorage({
     destination: function (req, file, cb) {
-        const uploadDir = path.join(__dirname, '../uploads/projects');
+        const uploadDir = path.join(config.uploadPath, 'projects');
         if (!fs.existsSync(uploadDir)) {
             fs.mkdirSync(uploadDir, { recursive: true });
         }
diff --git a/docker-compose.yml b/docker-compose.yml
index 2242aa9..edc0e4b 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -8,11 +8,13 @@ services:
       - TUDUDI_SESSION_SECRET=changeme-please-use-openssl
       - TUDUDI_INTERNAL_SSL_ENABLED=false
       - TUDUDI_ALLOWED_ORIGINS=http://localhost:3002
+      - TUDUDI_UPLOAD_PATH="/app/backend/uploads"
       # Runtime UID/GID configuration - set these to match your host user/group
       - PUID=1001
       - PGID=1001
     volumes:
       - ./tududi_db:/app/backend/db
+      #- ./uploads:/app/backend/uploads
     ports:
       - "3002:3002"
     restart: unless-stopped
diff --git a/scripts/docker-entrypoint.sh b/scripts/docker-entrypoint.sh
index e7a31e1..27e7722 100644
--- a/scripts/docker-entrypoint.sh
+++ b/scripts/docker-entrypoint.sh
@@ -62,9 +62,9 @@ else
 fi
 
 echo "Setting ownership of application directories to $TARGET_USER:$TARGET_GROUP"
-mkdir -p /app/backend/db /app/backend/certs
+mkdir -p /app/backend/db /app/backend/certs /app/backend/uploads
 chown -R "$TARGET_USER":"$TARGET_GROUP" /app/backend /app/scripts
-chmod 770 /app/backend/db /app/backend/certs
+chmod 770 /app/backend/db /app/backend/certs /app/backend/uploads
 set_db_file_permissions
 
 # Drop privileges and execute the original start script