tududi/backend/tests/unit/modules/oidc/auditService.test.js
Chris c2e9a1aa21
feat: Add OIDC/SSO authentication support (#1008)
* feat: add OIDC/SSO database schema and models (Phase 1)

Add database foundation for OpenID Connect authentication:

Database Migrations:
- Create oidc_identities table (links users to OIDC accounts)
- Create oidc_state_nonces table (OAuth state/nonce for CSRF protection)
- Create auth_audit_log table (security event logging)
- Make password_digest nullable in users table (allow OIDC-only users)

Models:
- OIDCIdentity: Links users to external OIDC providers
- OIDCStateNonce: Temporary OAuth state management
- AuthAuditLog: Authentication event audit trail

Changes:
- Updated User model to allow null password_digest
- Added model associations in models/index.js
- All migrations tested and verified

Related to #977

* feat: add OIDC core services (Phase 2)

- Install openid-client@^6.2.0 for OIDC protocol support
- Implement providerConfig.js for loading providers from .env
  - Support single provider or numbered providers (OIDC_PROVIDER_1_*, etc.)
  - Auto-provision and admin email domain configuration
  - Provider caching for performance
- Implement stateManager.js for OAuth state/nonce management
  - CSRF protection with 10-minute TTL
  - One-time use state consumption
  - Automatic cleanup of expired states
- Implement auditService.js for authentication event logging
  - Track login success/failure, logout, OIDC linking/unlinking
  - Store IP address, user agent, and metadata
  - Support for event queries and retention cleanup
- Add comprehensive unit tests (60 tests, all passing)
  - providerConfig: 36 tests for env parsing and validation
  - stateManager: 12 tests for state lifecycle and security
  - auditService: 12 tests for event logging and queries

Phase 2 completes the backend core services needed for OIDC authentication.

* feat: implement OIDC authentication flow (Phase 3)

Core OIDC Flow (service.js):
- Provider discovery with issuer caching
- Authorization URL generation with state/nonce
- OAuth callback handling and token exchange
- ID token validation using openid-client
- Token refresh functionality

JIT User Provisioning (provisioningService.js):
- Auto-create users from OIDC claims
- Link existing email accounts to OIDC identities
- Admin role assignment based on email domain rules
- Automatic username generation from email
- Transaction-safe identity creation

Identity Management (oidcIdentityService.js):
- List user's linked OIDC identities
- Link additional providers to existing accounts
- Unlink identities with safety checks
- Prevent unlinking last auth method
- Update identity claims on login

HTTP Layer (controller.js + routes.js):
- GET /api/oidc/providers - List configured providers
- GET /api/oidc/auth/:slug - Initiate OIDC flow
- GET /api/oidc/callback/:slug - Handle OAuth callback
- POST /api/oidc/link/:slug - Link provider to current user
- DELETE /api/oidc/unlink/:id - Unlink identity
- GET /api/oidc/identities - Get user's identities

Integration:
- Register OIDC routes in Express app (public + authenticated)
- Update auth service to reject password login for OIDC-only users
- Audit logging for all OIDC operations
- Session creation on successful authentication

Security:
- State/nonce CSRF protection
- One-time use state consumption
- Transaction-safe user provisioning
- Foreign key constraints enforced

* feat: implement OIDC frontend login flow (Phase 4)

- Created OIDCProviderButtons component for SSO login options
- Created OIDCCallback component for OAuth callback handling
- Updated Login page to fetch and display OIDC providers
- Added /auth/callback/:provider route to App.tsx
- Added i18n translations for OIDC UI elements
- Downgraded openid-client to v5.7.0 (CommonJS compatibility)
- Fixed linting issues in backend OIDC modules

Phase 4 completes the frontend login flow for OIDC/SSO authentication.
Users can now see configured SSO providers on the login page.

* feat: implement OIDC account linking UI (Phase 5)

Add Connected Accounts section to Profile Security tab allowing users to:
- View linked OIDC provider accounts
- Link new SSO providers to their account
- Unlink OIDC identities with validation
- Prevent unlinking last authentication method

Backend changes:
- Add has_password virtual field to User model
- Include has_password in profile API response
- Track whether user has password set for validation

Frontend changes:
- Create oidcService for OIDC API operations
- Create ConnectedAccounts component with link/unlink flows
- Add confirmation dialog before unlinking accounts
- Validate that users cannot unlink their last auth method
- Show warning if user has no password set
- Integrate Connected Accounts into SecurityTab

User experience:
- View all linked SSO provider accounts with email and link date
- Link additional providers via "Link Provider" buttons
- Unlink with two-step confirmation to prevent accidents
- Clear error messages when unlinking would leave no auth method
- Warning message suggesting password setup for OIDC-only users

Fixes #977

* feat: complete OIDC documentation and UI improvements (Phase 6)

This commit completes Phase 6 of the OIDC/SSO implementation with comprehensive
documentation, bug fixes, and UI reorganization.

Documentation:
- Add comprehensive user guide at docs/10-oidc-sso.md with:
  - Setup guides for 6 major providers (Google, Okta, Keycloak, Authentik, PocketID, Azure AD)
  - Configuration examples for single and multiple providers
  - User features documentation (login, account linking, management)
  - Advanced topics (auto-provisioning, admin role assignment, hybrid auth)
  - Comprehensive troubleshooting section
  - Security considerations and best practices
- Update README.md with OIDC/SSO section and quick setup examples

Internationalization:
- Add i18n support to OIDCProviderButtons component
- Add translation keys for all OIDC UI text
- Update English translations with "sign_in_with" key

Bug Fixes:
- Fix oidcService.ts to correctly unwrap API responses
  - Backend returns {providers: [...]} and {identities: [...]}
  - Frontend was expecting plain arrays, causing "map is not a function" error
- Fix initiateOIDCLink to properly handle POST response

UI Improvements:
- Move OIDC/SSO to dedicated tab in profile settings
  - Create new OIDCTab component with green LinkIcon
  - Remove ConnectedAccounts from SecurityTab
  - Add OIDC tab between Security and API Keys tabs
  - Update ProfileSettings with new tab configuration
- Security tab now focuses solely on password management

Testing:
- All linting passes
- All tests pass (82 suites, 1223 tests)

Related to #977

* feat: add OIDC/SSO translations for all 24 languages

Add i18n support for OIDC/SSO features across all supported languages:
- "Sign in with {{provider}}" button text
- "OIDC/SSO" tab label in profile settings
- OIDC authentication flow messages

Translations added for: Arabic, Bulgarian, Danish, German, Greek, Spanish,
Finnish, French, Indonesian, Italian, Japanese, Korean, Dutch, Norwegian,
Polish, Portuguese, Romanian, Russian, Slovenian, Swedish, Turkish,
Ukrainian, Vietnamese, and Chinese.

* fix: resolve 13 CodeQL security alerts

This commit addresses critical security vulnerabilities identified by CodeQL scanning:

**Security Configuration (2 fixes)**
- Fix insecure Helmet configuration - enable CSP and HSTS in production
- Fix clear text cookie transmission - enable secure cookies in production

**Path Injection (3 fixes)**
- Add path validation in users/controller.js to prevent arbitrary file deletion
- Add path validation in users/service.js for avatar operations
- Add path sanitization in attachment-utils.js deleteFileFromDisk function

**Cross-Site Scripting (1 fix)**
- Fix XSS vulnerability in GeneralTab.tsx avatar URL handling
- Add URL sanitization to prevent javascript: protocol attacks

**URL Security (2 fixes)**
- Fix double escaping in url/service.js HTML entity decoding
- Fix incomplete URL sanitization for YouTube domain validation

**Denial of Service (1 fix)**
- Add loop bound protection in inboxProcessingService.js (10k char limit)

**Rate Limiting (3 fixes)**
- Add rate limiting to auth routes (register, verify-email)
- Add rate limiting to task attachment upload/delete endpoints
- Add rate limiting to user avatar upload/delete endpoints

**GitHub Actions Security (1 fix)**
- Add explicit read-only permissions to CI workflow

Note: CSRF middleware (#10) requires frontend changes and is tracked separately.

Relates to PR #1008

* fix: allow test files in path validation for tests

* fix: format long condition in attachment-utils for Prettier compliance

Break the path validation condition across multiple lines to meet Prettier formatting requirements and fix CI linting failure.

* fix: resolve CodeQL security alerts

- Add rate limiting to OIDC authentication routes using authLimiter and authenticatedApiLimiter
- Implement CSRF protection middleware using csrf-sync (skips for API tokens and test environment)
- Add CSRF token endpoint at /api/csrf-token
- Fix incomplete URL scheme validation in GeneralTab to block all dangerous schemes (javascript:, data:, vbscript:, file:)

This addresses 5 high-severity CodeQL security vulnerabilities:
- Missing rate limiting on OIDC auth routes
- Missing CSRF middleware protection
- Incomplete URL sanitization in avatar handling

All 1223 tests passing.

* fix: implement CSRF protection with lusca for CodeQL compliance

Add CSRF protection using lusca.csrf (CodeQL's recommended library) to
protect session-based authentication while supporting hybrid auth patterns.

Implementation:
- Pre-check middleware marks exempt requests (test env, Bearer tokens)
- Lusca CSRF middleware applied with exemption flag check
- Session-based requests require valid x-csrf-token header
- Bearer token requests exempt (don't use cookies)
- Test environment exempt for test execution

This addresses CodeQL security alert js/missing-token-validation while
maintaining support for both cookie-based and token-based authentication.

Related: #977 (OIDC/SSO authentication feature)
2026-04-13 12:17:35 +03:00

354 lines
12 KiB
JavaScript

const auditService = require('../../../../modules/oidc/auditService');
const { AuthAuditLog, User } = require('../../../../models');
const { sequelize } = require('../../../../models');
const bcrypt = require('bcrypt');
describe('OIDC Audit Service', () => {
let mockReq;
let testUser;
beforeAll(async () => {
await sequelize.sync({ force: true });
});
afterAll(async () => {
await sequelize.close();
});
beforeEach(async () => {
await AuthAuditLog.destroy({ where: {}, truncate: true });
await User.destroy({ where: {}, truncate: true });
testUser = await User.create({
email: 'test@example.com',
password_digest: await bcrypt.hash('password123', 10),
});
mockReq = {
ip: '192.168.1.1',
connection: { remoteAddress: '192.168.1.1' },
get: jest.fn((header) => {
if (header === 'user-agent') return 'Mozilla/5.0 Test Browser';
return null;
}),
};
});
describe('EVENT_TYPES and AUTH_METHODS constants', () => {
it('should export EVENT_TYPES', () => {
expect(auditService.EVENT_TYPES).toBeDefined();
expect(auditService.EVENT_TYPES.LOGIN_SUCCESS).toBe(
'login_success'
);
expect(auditService.EVENT_TYPES.LOGIN_FAILED).toBe('login_failed');
expect(auditService.EVENT_TYPES.OIDC_LINKED).toBe('oidc_linked');
});
it('should export AUTH_METHODS', () => {
expect(auditService.AUTH_METHODS).toBeDefined();
expect(auditService.AUTH_METHODS.EMAIL_PASSWORD).toBe(
'email_password'
);
expect(auditService.AUTH_METHODS.OIDC).toBe('oidc');
expect(auditService.AUTH_METHODS.API_TOKEN).toBe('api_token');
});
});
describe('logEvent', () => {
it('should create audit log entry', async () => {
await auditService.logEvent({
userId: testUser.id,
eventType: 'login_success',
authMethod: 'email_password',
ipAddress: '192.168.1.1',
userAgent: 'Test Browser',
});
const logs = await AuthAuditLog.findAll();
expect(logs).toHaveLength(1);
expect(logs[0].user_id).toBe(testUser.id);
expect(logs[0].event_type).toBe('login_success');
expect(logs[0].auth_method).toBe('email_password');
});
it('should store metadata as JSON string', async () => {
await auditService.logEvent({
userId: testUser.id,
eventType: 'login_failed',
authMethod: 'email_password',
metadata: {
email: 'test@example.com',
reason: 'invalid_password',
},
});
const log = await AuthAuditLog.findOne();
expect(log.metadata).toBe(
'{"email":"test@example.com","reason":"invalid_password"}'
);
});
it('should handle null userId for failed login attempts', async () => {
await auditService.logEvent({
userId: null,
eventType: 'login_failed',
authMethod: 'email_password',
});
const log = await AuthAuditLog.findOne();
expect(log.user_id).toBeNull();
});
it('should not throw on logging errors', async () => {
await expect(
auditService.logEvent({
userId: 999999,
eventType: null,
authMethod: null,
})
).resolves.not.toThrow();
});
});
describe('logLoginSuccess', () => {
it('should log successful email/password login', async () => {
await auditService.logLoginSuccess(
testUser.id,
auditService.AUTH_METHODS.EMAIL_PASSWORD,
mockReq
);
const log = await AuthAuditLog.findOne();
expect(log.user_id).toBe(testUser.id);
expect(log.event_type).toBe('login_success');
expect(log.auth_method).toBe('email_password');
expect(log.ip_address).toBe('192.168.1.1');
expect(log.user_agent).toBe('Mozilla/5.0 Test Browser');
expect(log.provider_slug).toBeNull();
});
it('should log successful OIDC login with provider', async () => {
await auditService.logLoginSuccess(
testUser.id,
auditService.AUTH_METHODS.OIDC,
mockReq,
'google'
);
const log = await AuthAuditLog.findOne();
expect(log.user_id).toBe(testUser.id);
expect(log.event_type).toBe('login_success');
expect(log.auth_method).toBe('oidc');
expect(log.provider_slug).toBe('google');
});
});
describe('logLoginFailed', () => {
it('should log failed login attempt with email', async () => {
await auditService.logLoginFailed(
'test@example.com',
auditService.AUTH_METHODS.EMAIL_PASSWORD,
mockReq,
null,
'invalid_password'
);
const log = await AuthAuditLog.findOne();
expect(log.user_id).toBeNull();
expect(log.event_type).toBe('login_failed');
expect(log.auth_method).toBe('email_password');
const metadata = JSON.parse(log.metadata);
expect(metadata.email).toBe('test@example.com');
expect(metadata.reason).toBe('invalid_password');
});
it('should log failed OIDC attempt', async () => {
await auditService.logLoginFailed(
'user@example.com',
auditService.AUTH_METHODS.OIDC,
mockReq,
'google',
'auto_provision_disabled'
);
const log = await AuthAuditLog.findOne();
expect(log.provider_slug).toBe('google');
expect(log.auth_method).toBe('oidc');
});
});
describe('logLogout', () => {
it('should log logout event', async () => {
await auditService.logLogout(testUser.id, mockReq);
const log = await AuthAuditLog.findOne();
expect(log.user_id).toBe(testUser.id);
expect(log.event_type).toBe('logout');
expect(log.ip_address).toBe('192.168.1.1');
});
});
describe('logOidcLinked', () => {
it('should log OIDC account linking', async () => {
await auditService.logOidcLinked(testUser.id, 'google', mockReq);
const log = await AuthAuditLog.findOne();
expect(log.user_id).toBe(testUser.id);
expect(log.event_type).toBe('oidc_linked');
expect(log.auth_method).toBe('oidc');
expect(log.provider_slug).toBe('google');
});
});
describe('logOidcUnlinked', () => {
it('should log OIDC account unlinking', async () => {
await auditService.logOidcUnlinked(testUser.id, 'okta', mockReq);
const log = await AuthAuditLog.findOne();
expect(log.user_id).toBe(testUser.id);
expect(log.event_type).toBe('oidc_unlinked');
expect(log.provider_slug).toBe('okta');
});
});
describe('logOidcProvision', () => {
it('should log new user provisioning', async () => {
await auditService.logOidcProvision(
testUser.id,
'google',
mockReq,
true
);
const log = await AuthAuditLog.findOne();
expect(log.user_id).toBe(testUser.id);
expect(log.event_type).toBe('oidc_provision');
expect(log.provider_slug).toBe('google');
const metadata = JSON.parse(log.metadata);
expect(metadata.isNewUser).toBe(true);
});
it('should log existing user provisioning', async () => {
await auditService.logOidcProvision(
testUser.id,
'okta',
mockReq,
false
);
const log = await AuthAuditLog.findOne();
const metadata = JSON.parse(log.metadata);
expect(metadata.isNewUser).toBe(false);
});
});
describe('getRecentEvents', () => {
beforeEach(async () => {
for (let i = 1; i <= 60; i++) {
await auditService.logEvent({
userId: testUser.id,
eventType: 'login_success',
authMethod: 'email_password',
});
}
});
it('should return recent events for user', async () => {
const events = await auditService.getRecentEvents(testUser.id);
expect(events).toHaveLength(50);
});
it('should return events in descending order', async () => {
const events = await auditService.getRecentEvents(testUser.id, 5);
expect(events).toHaveLength(5);
for (let i = 0; i < events.length - 1; i++) {
expect(
new Date(events[i].created_at) >=
new Date(events[i + 1].created_at)
).toBe(true);
}
});
it('should respect custom limit', async () => {
const events = await auditService.getRecentEvents(testUser.id, 10);
expect(events).toHaveLength(10);
});
it('should return empty array for user with no events', async () => {
const events = await auditService.getRecentEvents(999);
expect(events).toHaveLength(0);
});
});
describe('cleanupOldLogs', () => {
beforeEach(async () => {
await auditService.logEvent({
userId: testUser.id,
eventType: 'login_success',
authMethod: 'email_password',
});
const oldLog = await AuthAuditLog.create({
user_id: testUser.id,
event_type: 'login_success',
auth_method: 'email_password',
created_at: new Date(Date.now() - 100 * 24 * 60 * 60 * 1000),
});
});
it('should delete logs older than specified days', async () => {
const deletedCount = await auditService.cleanupOldLogs(90);
expect(deletedCount).toBe(1);
const remaining = await AuthAuditLog.count();
expect(remaining).toBe(1);
});
it('should not delete recent logs', async () => {
const deletedCount = await auditService.cleanupOldLogs(200);
expect(deletedCount).toBe(0);
const remaining = await AuthAuditLog.count();
expect(remaining).toBe(2);
});
it('should respect custom retention period', async () => {
const deletedCount = await auditService.cleanupOldLogs(30);
expect(deletedCount).toBe(1);
});
});
describe('IP address handling', () => {
it('should use req.ip if available', async () => {
mockReq.ip = '10.0.0.1';
await auditService.logLoginSuccess(
testUser.id,
'email_password',
mockReq
);
const log = await AuthAuditLog.findOne();
expect(log.ip_address).toBe('10.0.0.1');
});
it('should fallback to req.connection.remoteAddress', async () => {
mockReq.ip = null;
mockReq.connection.remoteAddress = '172.16.0.1';
await auditService.logLoginSuccess(
testUser.id,
'email_password',
mockReq
);
const log = await AuthAuditLog.findOne();
expect(log.ip_address).toBe('172.16.0.1');
});
});
});