marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix inconsistent Tab/Workspace terminology in settings and menus (#187)

Browse source 
Unify user-facing labels to consistently use "Workspace" instead of
mixing "Tab" and "Workspace":

- Settings: "New Tab" → "New Workspace" (keyboard shortcuts section)
- Menu: "Tab 1"–"Tab 9" → "Workspace 1"–"Workspace 9" (Cmd+1–9)
- Sidebar context menu: "Close Tabs" → "Close Workspaces",
  "Close Tabs Below/Above" → "Close Workspaces Below/Above"

Fixes https://github.com/manaflow-ai/cmux/issues/182

Co-authored-by: austinpower1258 <austinwang115@gmail.com>
This commit is contained in:
Lawrence Chen 2026-02-20 14:58:58 -08:00 • committed by GitHub
parent 1650ba372f
commit 573cec4a75
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Sources/ContentView.swift
View file

@ -1988,7 +1988,7 @@ private struct TabItemView: View {
Divider()
Button("Close Tabs") {
Button("Close Workspaces") {
closeTabs(targetIds, allowPinned: true)
}
.disabled(targetIds.isEmpty)
@ -1998,12 +1998,12 @@ private struct TabItemView: View {
}
.disabled(tabManager.tabs.count <= 1 || targetIds.count == tabManager.tabs.count)
Button("Close Tabs Below") {
Button("Close Workspaces Below") {
closeTabsBelow(tabId: tab.id)
}
.disabled(index >= tabManager.tabs.count - 1)
Button("Close Tabs Above") {
Button("Close Workspaces Above") {
closeTabsAbove(tabId: tab.id)
}
.disabled(index == 0)

2
Sources/KeyboardShortcutSettings.swift
View file

@ -35,7 +35,7 @@ enum KeyboardShortcutSettings {
var label: String {
switch self {
case .toggleSidebar: return "Toggle Sidebar"
case .newTab: return "New Tab"
case .newTab: return "New Workspace"
case .newWindow: return "New Window"
case .showNotifications: return "Show Notifications"
case .jumpToUnread: return "Jump to Latest Unread"

2
Sources/cmuxApp.swift
View file

@ -467,7 +467,7 @@ struct cmuxApp: App {
// Cmd+1 through Cmd+9 for workspace selection (9 = last workspace)
ForEach(1...9, id: \.self) { number in
Button("Tab \(number)") {
Button("Workspace \(number)") {
let manager = (AppDelegate.shared?.tabManager ?? tabManager)
if let targetIndex = WorkspaceShortcutMapper.workspaceIndex(forCommandDigit: number, workspaceCount: manager.tabs.count) {
manager.selectTab(at: targetIndex)