marketing-shibata50/cmux
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix notification ring not appearing on terminal panes

Browse source 
TerminalPanelView and PanelContentView held notificationStore as a
plain `let` property. Since it's a reference type (class), SwiftUI's
structural diffing saw no change when notifications were added and
skipped re-evaluating the view body. Changed to @ObservedObject var
so the views properly subscribe to the store's @Published changes.

Closes #126
This commit is contained in:
Lawrence Chen 2026-02-19 22:46:17 -08:00
parent d74d2afb01
commit cef1513ceb
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Sources/Panels/PanelContentView.swift
View file

@ -10,7 +10,7 @@ struct PanelContentView: View {
let portalPriority: Int
let isSplit: Bool
let appearance: PanelAppearance
let notificationStore: TerminalNotificationStore
@ObservedObject var notificationStore: TerminalNotificationStore
let onFocus: () -> Void
let onRequestPanelFocus: () -> Void
let onTriggerFlash: () -> Void

2
Sources/Panels/TerminalPanelView.swift
View file

@ -10,7 +10,7 @@ struct TerminalPanelView: View {
let portalPriority: Int
let isSplit: Bool
let appearance: PanelAppearance
let notificationStore: TerminalNotificationStore
@ObservedObject var notificationStore: TerminalNotificationStore
let onFocus: () -> Void
let onTriggerFlash: () -> Void